From owner-svn-src-head@FreeBSD.ORG Sun Nov 16 05:26:11 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E7E37B39; Sun, 16 Nov 2014 05:26:10 +0000 (UTC) Received: from mail-pd0-x231.google.com (mail-pd0-x231.google.com [IPv6:2607:f8b0:400e:c02::231]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id AE4A49AF; Sun, 16 Nov 2014 05:26:10 +0000 (UTC) Received: by mail-pd0-f177.google.com with SMTP id v10so19025242pde.22 for ; Sat, 15 Nov 2014 21:26:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :message-id:references:to; bh=Uq/r9+i4JjqdkBH+wIIbVylW0NO75d7K5tRnBYQ9rqQ=; b=WtfTrnowUp+viIEENgcL7BUbLUDbZeV/ORvgEjpqg0S/1oQR6LL8fFXSLgs+0F9zKU wuGyrX+QUmoXWY5VALPZDwdwNRRDS//3Nr7aoo9VNd4vNejztYqh6HK1eEFjyps3vVAP HI1trmaM92Yqukj4SPVwj1SeS95MTFWaat8Pi2COkCx3HSI+cRjN7VtmPwnS3ikPU3I/ pm2gO3jjIp26Goctpm+iqhJIwJgslnBmVbw/1fOxm3YWKC48wZZK5KuIbGfg58AEmfTx kcnbaQYjukwFIi4hwYG0oPypYVcx4EWei3oEeUtKzhE5/j5En0xJGRZ+B/vWoPe8Fk/c Xd5A== X-Received: by 10.66.188.167 with SMTP id gb7mr20948485pac.23.1416115570240; Sat, 15 Nov 2014 21:26:10 -0800 (PST) Received: from ?IPv6:2601:8:ab80:7d6:29f3:7219:6a42:c3? ([2601:8:ab80:7d6:29f3:7219:6a42:c3]) by mx.google.com with ESMTPSA id yc4sm31757736pab.27.2014.11.15.21.26.09 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 15 Nov 2014 21:26:09 -0800 (PST) Content-Type: multipart/signed; boundary="Apple-Mail=_F8772231-BC84-4605-BE87-DB4A39B987D2"; protocol="application/pgp-signature"; micalg=pgp-sha512 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: svn commit: r274573 - head/contrib/netbsd-tests/lib/libpthread From: Garrett Cooper In-Reply-To: <54683508.3030104@freebsd.org> Date: Sat, 15 Nov 2014 21:26:08 -0800 Message-Id: References: <201411160508.sAG58JdG055637@svn.freebsd.org> <546833FE.9060904@freebsd.org> <45B1482F-352E-4874-8A89-1EC225A32E93@gmail.com> <54683508.3030104@freebsd.org> To: Alfred Perlstein X-Mailer: Apple Mail (2.1878.6) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Garrett Cooper X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Nov 2014 05:26:11 -0000 --Apple-Mail=_F8772231-BC84-4605-BE87-DB4A39B987D2 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On Nov 15, 2014, at 21:24, Alfred Perlstein wrote: > On 11/15/14, 9:22 PM, Garrett Cooper wrote: >> On Nov 15, 2014, at 21:19, Alfred Perlstein = wrote: >>=20 >>> This looks easy enough to fix under _thr_find_thread() in libthread. >>>=20 >>> Any interest in fixing it? >> Yes, if it=92s POSIXly correct and doesn=92t break everything else. >>=20 >>> Might be worth hacking _thr_find_thread() to take an ERRNO to return = based on NULL until we chase down all the paths into it just in case = EINVAL is a valid ptr. >> K. Thanks for the hint! >>=20 >>> Also, just wondering what happens on other platforms, does it elicit = a crash? Ie. is NULL a safe value to pass in on other platforms? >> I wish I knew what happened on !x86 platforms=85 I honestly don=92t = have access to ARM/MIPS/PowerPC, so I can=92t say :/. >>=20 >> Thanks! >=20 > Oh, I meant Linux and Solaris, or even other BSD. Ah, good question. pho@ ran some of the tests in contrib/netbsd-tests on = Linux/OSX before to do a side-by-side comparison, but I haven=92t setup = the necessary environment to do that testing [yet]. --Apple-Mail=_F8772231-BC84-4605-BE87-DB4A39B987D2 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJUaDVwAAoJEMZr5QU6S73e+V0H/0e+fH3FN4BfXneSMSd57va3 bw33x/Mp7LfsCBtRuTzXdO3zdkNxWFgih5N62TM8VhAzkvzHoVXg7dl+/BZrVkwL eDROZTikq+1T1iTmJTkm4piYjoJAAU6pAENF2+XFGocEgeqhaa3SDv/Pyks/sGSw vOSV1EeX0eeM0F5vfw6NRe58tSi8aeV5kTu/fLEMJ6+afH+WJ/k/dfGVt08HXqUJ mm++jTSbciBXBmSvLiyfAV5M9zr1rbFQhbATYIQoLKhq2xM2Z5yOMGosLSkrmdty rX/UxzEXs7LvYKzvGwO3u99VEYo52wGvGIy5fC8zfUCPu8nNrD38a50rqfsB8Sw= =DJfS -----END PGP SIGNATURE----- --Apple-Mail=_F8772231-BC84-4605-BE87-DB4A39B987D2--