From owner-svn-src-all@freebsd.org Mon Jan 15 12:26:11 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 13B5CE7A068; Mon, 15 Jan 2018 12:26:11 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9EF247231C; Mon, 15 Jan 2018 12:26:10 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id w0FCPuQu002647 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 15 Jan 2018 14:26:00 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua w0FCPuQu002647 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id w0FCPupV002645; Mon, 15 Jan 2018 14:25:56 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Mon, 15 Jan 2018 14:25:56 +0200 From: Konstantin Belousov To: Andriy Gapon Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r327996 - in head/sys: cam/scsi geom Message-ID: <20180115122556.GH1684@kib.kiev.ua> References: <201801151120.w0FBK0Jf006161@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201801151120.w0FBK0Jf006161@repo.freebsd.org> User-Agent: Mutt/1.9.2 (2017-12-15) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jan 2018 12:26:11 -0000 On Mon, Jan 15, 2018 at 11:20:00AM +0000, Andriy Gapon wrote: > Author: avg > Date: Mon Jan 15 11:20:00 2018 > New Revision: 327996 > URL: https://svnweb.freebsd.org/changeset/base/327996 > > Log: > geom_disk / scsi_da: deny opening write-protected disks for writing > > Ths change consists of two parts. > > geom_disk: deny opening a disk for writing if it's marked as > write-protected. A new disk(9) flag is added to mark write protected > disks. A possible alternative could be to add another parameter to d_open, > so that the open mode could be passed to it and the disk drivers could > make the decision internally, but the flag required less churn. If you need the mode, use d_fdopen cdevsw method.