From owner-freebsd-current@FreeBSD.ORG  Mon Jul  3 18:45:30 2006
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: freebsd-current@freebsd.org
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 0CD5C16A407;
	Mon,  3 Jul 2006 18:45:30 +0000 (UTC)
	(envelope-from fli+freebsd-current@shapeshifter.se)
Received: from mx1.h3q.net (manticore.shapeshifter.se [212.37.5.30])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 7EF2243D45;
	Mon,  3 Jul 2006 18:45:29 +0000 (GMT)
	(envelope-from fli+freebsd-current@shapeshifter.se)
Received: from localhost (localhost [127.0.0.1])
	by mx1.h3q.net (Postfix) with ESMTP id 2B53A1A734;
	Mon,  3 Jul 2006 20:45:27 +0200 (CEST)
Received: from mx1.h3q.net ([127.0.0.1])
	by localhost (mx1.h3q.net [127.0.0.1]) (amavisd-new,
	port 10024) with ESMTP
	id 90215-06; Mon,  3 Jul 2006 20:45:25 +0200 (CEST)
Received: from [192.168.1.100] (217-208-33-252-o926.tbon.telia.com
	[217.208.33.252])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.h3q.net (Postfix) with ESMTP id 497D21A6B2;
	Mon,  3 Jul 2006 20:45:25 +0200 (CEST)
Message-ID: <44A965BD.70101@shapeshifter.se>
Date: Mon, 03 Jul 2006 20:45:17 +0200
From: Fredrik Lindberg <fli+freebsd-current@shapeshifter.se>
User-Agent: Thunderbird 1.5.0.2 (X11/20060423)
MIME-Version: 1.0
To: John-Mark Gurney <gurney_j@resnet.uoregon.edu>
References: <44A927AC.7080807@shapeshifter.se>
	<20060703181408.GB734@funkthat.com>
In-Reply-To: <20060703181408.GB734@funkthat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: amavisd-new at h3q.net
Cc: freebsd-current@freebsd.org, "Christian S. J. Peron" <csjp@FreeBSD.org>
Subject: Re: panic: knlist locked, but should not be
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Jul 2006 18:45:30 -0000

John-Mark Gurney wrote:
> 
> Why not drop the lock lines and keep the 0?  As you said since it's
> the same lock, locking it a bit later won't hurt...
> 

A yes of course the locks can be dropped from filt_bpfdetach(), that's
probably better. But bpfkqfilter() will have to keep its lock because it
modifies data. The lines could also be swapped (releasing the lock
before calling knlist_add) but that would just be stupid as the lock
would be acquired again in knlist_add.

Fredrik Lindberg