From owner-svn-src-stable-11@freebsd.org Wed Mar 7 22:54:21 2018 Return-Path: Delivered-To: svn-src-stable-11@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0F8F1F39D4F for ; Wed, 7 Mar 2018 22:54:21 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-yb0-x234.google.com (mail-yb0-x234.google.com [IPv6:2607:f8b0:4002:c09::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A3566747D6 for ; Wed, 7 Mar 2018 22:54:20 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: by mail-yb0-x234.google.com with SMTP id u5-v6so1381123ybf.4 for ; Wed, 07 Mar 2018 14:54:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=TSC5i61gO55t7/zY0wfcOQe+yuYKAzaUQyM3I0MTyZQ=; b=DIPTD3a4X1IbrlReBN1+VS6TMSXhOiuAcg4ddtVSkKOWweytADllVqwR80bTjIGSl5 fnxtlUw70kMmd0fGkVC02HBvIdQbu6SC6PZCzlgp2xuxNkBPBg11RVxTZ2P+pdPTmodf BhLvf4mV+xpfarVUIHw+Df2biX2fWBfvxXAwI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=TSC5i61gO55t7/zY0wfcOQe+yuYKAzaUQyM3I0MTyZQ=; b=nurYvgEkUBrc+nGD4NK+KFoeg6nT4mAYPQ2br5ZbGZVfsTyHpp7Kl2VyCkUGEhYeKa M29qZtoEePVzTrCMkTiogRBytVXq6yglzCDjCUNYUVKzjGevW75HLhB+Vh8Scn1wwuRH DCBL1D3gawJdKn2n+EgXW4XHguC63bGfih7mRhyuG5+/bNVkWeQvHrKR5RncwCMc7Z1a yhHmK4svu9xN/fYZyllnB2WU+kQKbSxoUSZh3iwwK1+lpkWiqAAq2Shpg/l3badWwvsG urzEjxWI6D8JodDawAQ8p3okSwvxDIMjsehpuQ9D6O9YotFgtvg6J24jV48A6z0d28RR jPog== X-Gm-Message-State: APf1xPCRkSXmIVMdu/ZBTWYinS+t3zlUgwAhnPZgZyY3Am0ZUwwvb1fL n/2EfuElqVRmWNRQ5pzKokc7M8ggtnpClSQedUec0g== X-Google-Smtp-Source: AG47ELsjttXVBOFSoHcfY8ZkNnvxluffLRortGjj12xWZR7Ud+cmrDPPxkVaSvfWa/XmzUqeV82+N/5ap6cYyxD18gM= X-Received: by 2002:a25:e5c7:: with SMTP id c190-v6mr15394895ybh.338.1520463259894; Wed, 07 Mar 2018 14:54:19 -0800 (PST) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 2002:a25:23d2:0:0:0:0:0 with HTTP; Wed, 7 Mar 2018 14:53:49 -0800 (PST) In-Reply-To: <8377086.JrIgVVMXMv@ralph.baldwin.cx> References: <201803050754.w257swAE001435@repo.freebsd.org> <6465173.s2nWvWCLOs@ralph.baldwin.cx> <8377086.JrIgVVMXMv@ralph.baldwin.cx> From: Eitan Adler Date: Wed, 7 Mar 2018 14:53:49 -0800 X-Google-Sender-Auth: QjtyHAfa52OuR3dgYd85NjRfyXc Message-ID: Subject: Re: svn commit: r330451 - in stable/11/sys: dev/iwm dev/otus dev/usb/wlan net80211 To: John Baldwin Cc: src-committers , svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-stable-11@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for only the 11-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Mar 2018 22:54:21 -0000 On 7 March 2018 at 09:37, John Baldwin wrote: > On Tuesday, March 06, 2018 06:46:37 PM Eitan Adler wrote: >> On 6 March 2018 at 08:26, John Baldwin wrote: >> > On Monday, March 05, 2018 07:13:59 PM Eitan Adler wrote: >> >> On 5 March 2018 at 10:08, John Baldwin wrote: >> >> > On Monday, March 05, 2018 07:54:58 AM Eitan Adler wrote: >> >> >> Author: eadler >> >> >> Date: Mon Mar 5 07:54:57 2018 >> >> >> New Revision: 330451 >> >> >> URL: https://svnweb.freebsd.org/changeset/base/330451 >> >> >> >> >> >> Log: >> >> >> MFC r306837: >> >> >> >> >> >> [net80211] extend the ieee80211_rx_stats struct to include more information. >> >> > >> >> > Have you thought about the KBI implications of this change and some of the >> >> > other changes you've merged? >> >> >> >> I do have a copy of the modules from 11.1 and have loaded them at >> >> various points in time after merging. That said, I am not perfect. >> >> Unfortunately, my -STABLE box did not have fully functioning drivers >> >> before these changes so its difficult to test anything beyond "loads >> >> and does not panic.". I havn't done so today yet, but that will happen >> >> soon. >> >> >> >> Ensuring these things work through code inspection is certainly >> >> possible and I've skipped over several changes as a result. >> > >> > Loading a module doesn't alone doesn't actually test for breakage. >> >> I'm aware. In this case I should likely just revert this change since >> its a pretty blatant break. > > I suspect many of these changes for iwm, etc. are all intertwined so I'm not > sure if you can leave out individual ones. Possibly. I do have iwm working on my laptop though. I also know of one open PR assigned to me w.r.t. a model I don't own. I'll be addressing it some time this week. >> > Batching >> > up changes into a single diff is also helpful since if an API changes back >> > and forth in HEAD multiple times, collapsing them means that for stable you >> > may only need a single compat shim rather than several. >> >> Understood. My intention in doing them one-by-one was to make it >> easier to bisect if something goes wrong. > > For stable I think we also want to balance this with: > > 1) Not putting stable in a known-broken state. If there are followup fixes > either for compile or runtime performances, those followup fixes should > always be included in the commit that merges the original change. To the extent possible I tried to do this. > 2) Preserving ABI. The desire to avoid putting stable into known-broken > state means that MFCs should include the ABI shims along with the original > change. This part I missed very clearly. I'll be sure to be more careful in the future. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams