From owner-freebsd-bugs@FreeBSD.ORG Tue Jun 26 23:00:15 2007 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 2B8C516A41F for ; Tue, 26 Jun 2007 23:00:15 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id CBF8613C447 for ; Tue, 26 Jun 2007 23:00:14 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l5QN0EUk082549 for ; Tue, 26 Jun 2007 23:00:14 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l5QN0EZY082548; Tue, 26 Jun 2007 23:00:14 GMT (envelope-from gnats) Date: Tue, 26 Jun 2007 23:00:14 GMT Message-Id: <200706262300.l5QN0EZY082548@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: Remko Lodder Cc: Subject: Re: kern/114057: devfs symlink over device doesn't work X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Remko Lodder List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jun 2007 23:00:15 -0000 The following reply was made to PR kern/114057; it has been noted by GNATS. From: Remko Lodder To: Stef Walter Cc: freebsd-gnats-submit@FreeBSD.org Subject: Re: kern/114057: devfs symlink over device doesn't work Date: Wed, 27 Jun 2007 00:51:46 +0200 Stef Walter wrote: > >> How-To-Repeat: > # cd /dev > # rm console > # touch /var/log/console > # ln -s /var/log/console console > # ls -l console > ls: console: No such file or directory > >> Fix: > > > Patch attached with submission follows: > > --- sys/fs/devfs/devfs_vnops.c.orig Mon Oct 30 15:46:29 2006 > +++ sys/fs/devfs/devfs_vnops.c Tue Jun 26 16:16:24 2007 > @@ -1263,7 +1263,7 @@ > #ifdef MAC > mac_create_devfs_symlink(ap->a_cnp->cn_cred, dmp->dm_mount, dd, de); > #endif > - TAILQ_INSERT_TAIL(&dd->de_dlist, de, de_list); > + TAILQ_INSERT_HEAD(&dd->de_dlist, de, de_list); > return (devfs_allocv(de, ap->a_dvp->v_mount, ap->a_vpp, td)); > } > > (i am unfamiliar with devfs): Isn't this somethign that devfs maintains? If you remove something under /dev then devfs doesn't take that into account yet, and any new thing arriving there which isn't under control of devfs gets ignored? In my opinion now that we have devfs, that should manage everything in /dev and if you want to do something fancy with that, it falls outside of regular configurations and thus might or might not work. That said I will repeat that i am unfamiliar with devfs so the idea behind it might be totally different from what I think is the focus for devfs. Regards, remko -- Kind regards, Remko Lodder ** remko@elvandar.org FreeBSD ** remko@FreeBSD.org /* Quis custodiet ipsos custodes */