From owner-svn-src-all@freebsd.org Tue Apr 9 21:13:52 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 68664156DE6D; Tue, 9 Apr 2019 21:13:52 +0000 (UTC) (envelope-from crees@bayofrum.net) Received: from mail37c50.megamailservers.eu (mail161c50.megamailservers.eu [91.136.10.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2631582504; Tue, 9 Apr 2019 21:13:49 +0000 (UTC) (envelope-from crees@bayofrum.net) X-Authenticated-User: bayofrum@uwclub.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1554844422; bh=xB+kUJohUV/vOe8kjn9BfM0LRU8JJS8f9huPhn84V3M=; h=Date:In-Reply-To:References:Subject:To:CC:From:From; b=PEK0yL5mMV+TyYQ5aC+DT5bILNog8uC0XLnz2j3JC/EKNG9mEigyiHMm4Ki4Hum65 9a5TKKbB88yoaz4b5wp1aHGEdebgF3ctCofWdFfZYnwy1uCJVx1RsLek5UAzixc4Op JpymyvSJqGfAnuo6bK3e2YyvfOPBx1jtWEaRijOA= Feedback-ID: crees@bayofrum. Received: from pegasus.bayofrum.net (81-178-238-70.dsl.pipex.com [81.178.238.70]) (authenticated bits=0) by mail37c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x39LDeAM011779; Tue, 9 Apr 2019 21:13:41 +0000 Received: from R.bayofrum.net (R.bayofrum.net [192.168.1.129]) by pegasus.bayofrum.net (Postfix) with ESMTPSA id 843C31E46; Tue, 9 Apr 2019 22:13:31 +0100 (BST) Date: Tue, 09 Apr 2019 22:13:29 +0100 User-Agent: K-9 Mail for Android In-Reply-To: <201904092108.x39L8ZCG062247@gndrsh.dnsmgr.net> References: <201904092108.x39L8ZCG062247@gndrsh.dnsmgr.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: svn commit: r346017 - in head: libexec/rc libexec/rc/rc.d share/man/man5 To: rgrimes@freebsd.org, "Rodney W. Grimes" , Chris Rees CC: Andriy Gapon , "O. Hartmann" , Chris Rees , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Chris Rees Message-ID: <2B336327-528C-4E16-AA5D-B3497B1941D0@bayofrum.net> X-bayofrum-MailScanner-Information: Please contact the ISP for more information X-bayofrum-MailScanner-ID: 843C31E46.A4CB0 X-bayofrum-MailScanner: Found to be clean X-bayofrum-MailScanner-From: crees@bayofrum.net X-Spam-Status: No X-CTCH-RefID: str=0001.0A0B0210.5CAD0B06.002D, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=P4AUeBIu c=1 sm=1 tr=0 a=i0HMBnJGy7D3/NFKO8d8XA==:117 a=i0HMBnJGy7D3/NFKO8d8XA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=IkcTkHD0fZMA:10 a=oexKYjalfGEA:10 a=iKhvJSA4AAAA:8 a=J93aaXUkh_By0JStf2IA:9 a=QEXdDO2ut3YA:10 a=odh9cflL3HIXMm4fY7Wr:22 X-Rspamd-Queue-Id: 2631582504 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=fail (rsa verify failed) header.d=megamailservers.eu header.s=maildub header.b=PEK0yL5m X-Spamd-Result: default: False [-2.44 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RECEIVED_SPAMHAUS_PBL(0.00)[70.238.178.81.zen.spamhaus.org : 127.0.0.11]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_DKIM_REJECT(1.00)[megamailservers.eu:s=maildub]; NEURAL_HAM_LONG(-1.00)[-0.999,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[bayofrum.net]; NEURAL_HAM_MEDIUM(-0.95)[-0.951,0]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[megamailservers.eu:-]; MX_GOOD(-0.01)[www.bayofrum.net]; RCPT_COUNT_SEVEN(0.00)[9]; NEURAL_HAM_SHORT(-0.82)[-0.822,0]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:9115, ipnet:91.136.0.0/17, country:GB]; MID_RHS_MATCH_FROM(0.00)[]; IP_SCORE(-0.46)[ipnet: 91.136.0.0/17(-1.23), asn: 9115(-0.98), country: GB(-0.09)]; RCVD_IN_DNSWL_LOW(-0.10)[171.10.136.91.list.dnswl.org : 127.0.5.1] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Apr 2019 21:13:52 -0000 On 9 April 2019 22:08:35 BST, "Rodney W. Grimes" wrote: >> On 09/04/2019 20:59, Chris Rees wrote: >> > On 9 April 2019 20:55:07 BST, "Rodney W. Grimes" > wrote: >> >>> On 09/04/2019 21:33, Rodney W. Grimes wrote: >> >>>> I think the trigger issue is: >> >>>> grep zfs /etc/rc.d/zvol >> >>>> rcvar=3D"zfs_enable" >> >>>> required_modules=3D"zfs" >> >>>> >> >>>> that module requires may be going south with the >> >>>> new code when the module is built into the kernel. >> >>> Maybe it's because the module's name is zfsctrl (for whatever >reason) >> >> while the >> >>> module file is named zfs.ko. >> >> I suspect that could also lead to issues with the new code. >> >> It seems to be failing to detect that zfs is infact functional in >the >> >> kernel, >> >> and blindly, or not so blindly, trying to load zfs,ko, which when >you >> >> build >> >> it into the kernel you usually do so without any modules built, so >> >> there is >> >> no /boot/kernel/zfs.ko, and even if you did build it any attempt >to >> >> load >> >> it would return an error. >> > Loading with it built in isn't a problem, as I showed earlier. >> > >> > Loading when it doesn't exist *is*. >> > >> > I'm torn. Either we could revert this, or add a check to the >required_modules function instead, which I think is the better >solution. >>=20 >> Hang on, >>=20 >> [crees@pegasus]~% sudo kldload -n zfsctrl && echo yes >> yes > >I think your testing the return value of sudo here? Sudo returns the child's return value. Chris >> [crees@pegasus]~% find /boot -name zfsctrl\* >> [crees@pegasus]~% >>=20 >> I think that, rather than speculating, we should wait for Oliver to=20 >> confirm that this is actually the problem, because I still don't >think=20 >> it is. >>=20 >> Chris >>=20 >>=20 >> --=20 >> This message has been scanned for viruses and >> dangerous content by MailScanner, and is >> believed to be clean. >>=20 >>=20 --=20 Sent from my Android device with K-9 Mail. Please excuse my brevity. --=20 This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.