From owner-freebsd-bugs@FreeBSD.ORG Mon Oct 16 19:12:23 2006 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B003816A4EA for ; Mon, 16 Oct 2006 19:12:23 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 75F9F43E6C for ; Mon, 16 Oct 2006 19:10:15 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k9GJABRQ076709 for ; Mon, 16 Oct 2006 19:10:11 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k9GJAB7Z076708; Mon, 16 Oct 2006 19:10:11 GMT (envelope-from gnats) Resent-Date: Mon, 16 Oct 2006 19:10:11 GMT Resent-Message-Id: <200610161910.k9GJAB7Z076708@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Mike Durian Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CAF4F16A417 for ; Mon, 16 Oct 2006 19:04:45 +0000 (UTC) (envelope-from durian@boogie.com) Received: from mailhost.boogie.com (mailhost.boogie.com [70.91.170.29]) by mx1.FreeBSD.org (Postfix) with ESMTP id A13AF4412D for ; Mon, 16 Oct 2006 18:57:29 +0000 (GMT) (envelope-from durian@boogie.com) Received: from boogie.com (man.boogie.com [192.168.1.3]) by mailhost.boogie.com (8.13.6/8.13.6) with ESMTP id k9GIv2gi048736 for ; Mon, 16 Oct 2006 12:57:02 -0600 (MDT) (envelope-from durian@fever.boogie.com) Received: from man.boogie.com (localhost [127.0.0.1]) by boogie.com (8.13.8/8.13.8) with ESMTP id k9GIv2Jl044809 for ; Mon, 16 Oct 2006 12:57:02 -0600 (MDT) (envelope-from durian@man.boogie.com) Received: (from durian@localhost) by man.boogie.com (8.13.8/8.13.6/Submit) id k9GIv1A2044803; Mon, 16 Oct 2006 12:57:01 -0600 (MDT) (envelope-from durian) Message-Id: <200610161857.k9GIv1A2044803@man.boogie.com> Date: Mon, 16 Oct 2006 12:57:01 -0600 (MDT) From: Mike Durian To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: bin/104478: ngctl Makefile doesn't observe NO_LIBPTHREAD X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Mike Durian List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Oct 2006 19:12:24 -0000 >Number: 104478 >Category: bin >Synopsis: ngctl Makefile doesn't observe NO_LIBPTHREAD >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Oct 16 19:10:10 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Mike Durian >Release: FreeBSD 6.2-PRERELEASE i386 >Organization: >Environment: System: FreeBSD man.boogie.com 6.2-PRERELEASE FreeBSD 6.2-PRERELEASE #0: Fri Oct 13 10:41:27 MDT 2006 root@man.boogie.com:/usr/obj/usr/src/sys/BOOGIE i386 >Description: I recently updated my kernel and tried to build an image using nanobsd.sh. The build failed with usr.sbin/ngctl, because the Makefile didn't know how to build libpthread. My nanobsd configuration file does define NO_LIBPTHREAD=YES. I believe the ngctl/Makefile 1.14.8.1 change which adds dependancies on libedit and libpthread unless RELEASE_CRUNCH is defined, should also exclude those dependancies if NO_LIBTHREAD is defined. >How-To-Repeat: Define NO_LIBTHREAD=YES in a nanobsd configuration file, or easier, in make.conf. Try to buildworld. >Fix: --- Makefile.orig Mon Oct 16 12:21:11 2006 +++ Makefile Mon Oct 16 12:21:56 2006 @@ -7,7 +7,7 @@ msg.c debug.c shutdown.c rmhook.c status.c types.c write.c WARNS?= 3 -.if defined(RELEASE_CRUNCH) +.if defined(RELEASE_CRUNCH) || defined(NO_LIBPTHREAD) NGCTL_NO_LIBEDIT= .endif >Release-Note: >Audit-Trail: >Unformatted: