From owner-freebsd-current Wed Sep 30 02:20:25 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id CAA00711 for freebsd-current-outgoing; Wed, 30 Sep 1998 02:20:25 -0700 (PDT) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from implode.root.com (implode.root.com [198.145.90.17]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id CAA00634 for ; Wed, 30 Sep 1998 02:20:16 -0700 (PDT) (envelope-from root@implode.root.com) Received: from implode.root.com (localhost [127.0.0.1]) by implode.root.com (8.8.5/8.8.5) with ESMTP id CAA04277; Wed, 30 Sep 1998 02:20:18 -0700 (PDT) Message-Id: <199809300920.CAA04277@implode.root.com> To: Julian Elischer cc: Terry Lambert , current@FreeBSD.ORG Subject: Re: VM mmap file extension bug still exists? In-reply-to: Your message of "Tue, 29 Sep 1998 18:49:34 PDT." From: David Greenman Reply-To: dg@root.com Date: Wed, 30 Sep 1998 02:20:17 -0700 Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG >> It's definitely a workaround. The real fix is to add a parementer to >> the mapping function. > >Ok here's the patch done the 'correct way' >I have looked at the problem with terry and he has convinced me that >there IS a problem there. Well, as I said in previous email, I'm not convinced that adding another argument to the pager_alloc functions is "correct", and I think your patches pretty well demonstrate that. It appears to me that in every case, the "size_in_bytes" is just the non-rounded/indexed version of the original "size" parameter, so why don't we simply change the definition of "size" to be an off_t number of bytes and then do the OFF_TO_IDX translation in the pager(s) as necessary, instead of at the caller? -DG David Greenman Co-founder/Principal Architect, The FreeBSD Project To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message