Date: Wed, 30 Sep 1998 02:20:17 -0700 From: David Greenman <dg@root.com> To: Julian Elischer <julian@whistle.com> Cc: Terry Lambert <tlambert@primenet.com>, current@FreeBSD.ORG Subject: Re: VM mmap file extension bug still exists? Message-ID: <199809300920.CAA04277@implode.root.com> In-Reply-To: Your message of "Tue, 29 Sep 1998 18:49:34 PDT." <Pine.BSF.3.95.980929182706.11107L-100000@current1.whistle.com>
next in thread | previous in thread | raw e-mail | index | archive | help
>> It's definitely a workaround. The real fix is to add a parementer to >> the mapping function. > >Ok here's the patch done the 'correct way' >I have looked at the problem with terry and he has convinced me that >there IS a problem there. Well, as I said in previous email, I'm not convinced that adding another argument to the pager_alloc functions is "correct", and I think your patches pretty well demonstrate that. It appears to me that in every case, the "size_in_bytes" is just the non-rounded/indexed version of the original "size" parameter, so why don't we simply change the definition of "size" to be an off_t number of bytes and then do the OFF_TO_IDX translation in the pager(s) as necessary, instead of at the caller? -DG David Greenman Co-founder/Principal Architect, The FreeBSD Project To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199809300920.CAA04277>