From owner-svn-src-all@FreeBSD.ORG Tue May 12 00:53:21 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A05BB6ED; Tue, 12 May 2015 00:53:21 +0000 (UTC) Received: from anubis.delphij.net (anubis.delphij.net [64.62.153.212]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "anubis.delphij.net", Issuer "StartCom Class 1 Primary Intermediate Server CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 7EA1E15E5; Tue, 12 May 2015 00:53:21 +0000 (UTC) Received: from zeta.ixsystems.com (unknown [12.229.62.2]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by anubis.delphij.net (Postfix) with ESMTPSA id BFCA82418; Mon, 11 May 2015 17:53:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=delphij.net; s=anubis; t=1431391994; x=1431406394; bh=5WlRx5LpgPgpA6kmi8fQfBx0ej/G2rmNRCC3leowzRo=; h=Date:From:Reply-To:To:Subject:References:In-Reply-To; b=IOSMR2mWWsXmk2JGHYlBJ2w6hF+eqXAj1WtPjajQbdahQJgaCmmcLZXycP8bZF884 ibGuoRP2vaOvjOT/UqLMoc7amPCe2MbYKHGBZo3wUgMN63fHNxApgA+dzoGBwKhoMO eRmEXK21dagL9HojvI8MzFerVzMdZdXxssLReoIU= Message-ID: <55514EFA.4040608@delphij.net> Date: Mon, 11 May 2015 17:53:14 -0700 From: Xin Li Reply-To: d@delphij.net Organization: The FreeBSD Project MIME-Version: 1.0 To: Bryan Drewery , Thomas Quinot , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r282736 - in head: . lib/libmd References: <201505102121.t4ALLr3A076661@svn.freebsd.org> <5551480E.90906@FreeBSD.org> In-Reply-To: <5551480E.90906@FreeBSD.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 May 2015 00:53:21 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On 05/11/15 17:23, Bryan Drewery wrote: > The libmd changes break pkg - so all packages. > > http://beefy6.nyi.freebsd.org/data/head-amd64-default/p386108_s282785/ logs/pkg-1.5.2.log > > > >> CCLD pkg-static /usr/lib/liblzma.a(check.o): In function >> `lzma_check_init': >> /usr/local/poudriere/jails/head-amd64/usr/src/lib/liblzma/../../contr ib/xz/src/liblzma/check/check.c:(.text+0x5e): >> undefined reference to `_libmd_SHA256_Init' >> /usr/lib/liblzma.a(check.o): In function `lzma_check_update': >> /usr/local/poudriere/jails/head-amd64/usr/src/lib/liblzma/../../contr ib/xz/src/liblzma/check/check.c:(.text+0xbf): >> undefined reference to `_libmd_SHA256_Update' >> /usr/lib/liblzma.a(check.o): In function `lzma_check_finish': >> /usr/local/poudriere/jails/head-amd64/usr/src/lib/liblzma/../../contr ib/xz/src/liblzma/check/check.c:(.text+0x10d): >> undefined reference to `_libmd_SHA256_Final' cc: error: linker >> command failed with exit code 1 (use -v to see invocation) *** >> [pkg-static] Error code 1 > > > Can you please just revert this and 282726 until they are working > and have a passing exp-run? Looks like this is because my change (r282775) which makes libmd a dependency of liblzma, while pkg didn't catch up with, and it's unrelated to libmd change. A quick hack would be: - --- src/Makefile.in.orig 2015-05-11 17:49:52.690333554 -0700 +++ src/Makefile.in 2015-05-11 17:50:03.427853585 -0700 @@ -617,7 +617,7 @@ $(top_builddir)/compat/libbsd_compat.la \ $(top_builddir)/external/libsbuf_static.la $(pkg_OBJECTS) \ @LIBJAIL_LIB@ @LDNS_LIBS@ @OS_LIBS@ -larchive -lz -lutil -lbz2 \ - - -llzma -lssl -lcrypto -lm $(am__append_1) $(am__append_2) \ + -lmd -llzma -lssl -lcrypto -lm $(am__append_1) $(am__append_2) \ $(am__append_3) DYNPROG = pkg @BUILD_STATIC_TRUE@pkg_static_LDFLAGS = -all-static But it would break earlier FreeBSD. Should I revert my change and request for a exp-run? Cheers, - -- Xin LI https://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.1.2 (FreeBSD) iQIcBAEBCgAGBQJVUU76AAoJEJW2GBstM+nsg2cP/i/t3SB59mnwdoqQi72KQNA0 z+N4FGufh0ULnsOTtkW5M+iUhTLqPk64NHYlQd7MlqQEle5UZgmKj8db35j/UJjL r1b+ERwOIgg8415umMPUVnexwwwOngxGIcaa7moE1HTKz2SCuC1NAypuXmhqyQ9p It49A9MKhkNKt9sVbV2vfm8R6UA2T9suwjOxvyEpf0fihdp2XcbNZ3raL6yPTNoN O/nxeWL4O2UQju17nKKMsTLBqWeJCGrY1htwyvpR8kDi53UDAeyZUF3MOnj9jIa7 L4RJg38hjZlctV5UzOlz1ThbOCI4hsz9jaIEsN/OCAWsh+RLHTIA21w09KT8mnkn Ch8ARY0na9sWOLxbYgF2uqK/Y4Cv64P0W33Smd9WtqlX84FY+sm/FjEbAglmCD0d KhTBNYEL/I+Rn3fe9VfUHWAiW5QTT6CHGKdDcKpI63hFjrp2MoNmB18vRop/IQ/9 RihTuVaF25XOnbbW/K8L9yajZos0Mkrvz75nnmr5dG3uJljbPN0o3nzNAXqKa20c q8ld2cGrCs4WjJtJfLmdtTSN1kbeY74pTseq+DlIixlaDOcec7phY/qDRXrjCvy1 K5Upi2fUhYScuGzmz3MEP+SmtOn+2juPO+hWIXd3iP9Vtin3VYw8pUWttQsqWYvh XP2zfiUjGOMNs4kx1BMD =rz9u -----END PGP SIGNATURE-----