From owner-cvs-all@FreeBSD.ORG Tue Apr 4 17:32:49 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7CA0416A400; Tue, 4 Apr 2006 17:32:49 +0000 (UTC) (envelope-from ariff@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 36DB543D48; Tue, 4 Apr 2006 17:32:49 +0000 (GMT) (envelope-from ariff@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id k34HWnIj078820; Tue, 4 Apr 2006 17:32:49 GMT (envelope-from ariff@repoman.freebsd.org) Received: (from ariff@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id k34HWnVt078819; Tue, 4 Apr 2006 17:32:49 GMT (envelope-from ariff) Message-Id: <200604041732.k34HWnVt078819@repoman.freebsd.org> From: Ariff Abdullah Date: Tue, 4 Apr 2006 17:32:49 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/dev/sound/pci csapcm.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Apr 2006 17:32:49 -0000 ariff 2006-04-04 17:32:49 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/sound/pci csapcm.c Log: MFC (revision 1.37) A pointer was checked for NULL after dereferencing it. The check is not needed here, except there's a bug which results in detaching the device twice. Move the NULL pointer check to the beginning of the function and convert it into a KASSERT. CID: 483 Found with: Coverity Prevent(tm) Approved by: re (scottl) Revision Changes Path 1.34.2.2 +4 -4 src/sys/dev/sound/pci/csapcm.c