From owner-cvs-all@FreeBSD.ORG Mon Jun 11 20:30:48 2007 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 50CC716A46D for ; Mon, 11 Jun 2007 20:30:48 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: from nz-out-0506.google.com (nz-out-0506.google.com [64.233.162.226]) by mx1.freebsd.org (Postfix) with ESMTP id 06F5C13C4AD for ; Mon, 11 Jun 2007 20:30:47 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: by nz-out-0506.google.com with SMTP id 14so1195511nzn for ; Mon, 11 Jun 2007 13:30:47 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=lD2+EIttUaP+GGoIX2J5giMfwqg6zcWd4BD3cMq3ZmYxzS5eZlNqbz7sfjZb30ZmXihs0i0rNhCyNI877Wuk5AXzGz0tjUE7O0C5sgo4ogygi7HsTa5mkAiymzr0yoNSMPch0B5U4OxtJ6x/pYiOgckT3IqggP+enunbq1bk2Zg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=t9kINQRqdp3/Iz/6IbXNksnbNPZmxa1yj/ukYZQwdYtt+6ffH7IcVdNLji2tcGX9epe9mmZmXyRW0pOhZhUko+qOotOBQYuyFy5UiAvTD5yWNCmtWiLpX0VwD8VBAbsGu7d3ecnOwVrAc20F2wxqzPKGqVNC/q0a/ppuN2gY3LA= Received: by 10.114.209.1 with SMTP id h1mr5916378wag.1181593846858; Mon, 11 Jun 2007 13:30:46 -0700 (PDT) Received: by 10.114.126.10 with HTTP; Mon, 11 Jun 2007 13:30:46 -0700 (PDT) Message-ID: <2a41acea0706111330v6a39cf84o495f6acf62ba7ff7@mail.gmail.com> Date: Mon, 11 Jun 2007 13:30:46 -0700 From: "Jack Vogel" To: "Sam Leffler" In-Reply-To: <466DACD6.4040606@errno.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200706112008.l5BK8CQ7033543@repoman.freebsd.org> <466DACD6.4040606@errno.com> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, Andre Oppermann , cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/net if.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jun 2007 20:30:48 -0000 On 6/11/07, Sam Leffler wrote: > Andre Oppermann wrote: > > andre 2007-06-11 20:08:12 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/net if.h > > Log: > > Add IFCAP_LRO flag for drivers to announce their TCP Large Receive Offload > > capabilities. > > > > Revision Changes Path > > 1.108 +1 -0 src/sys/net/if.h > > http://cvsweb.FreeBSD.org/src/sys/net/if.h.diff?r1=1.107&r2=1.108 > > > > > There are many offload capabilities defined that are not well thought > out. In particular we do not distinguish between ipv4 and ipv6 for > things like cksum and tso so there's no way to disable individual > features. The ability to tweak LRO is clearly needed and clearly belong > as an ifnet capability but unilateraly deciding this is the wrong approach. > > Sam We do distinguish between TSO4 and TSO6, its just that all the pieces for 6 arent actually there yet, you are right about the cksum granularity, but I'm not convinced its needed. You might be right on the need to fine tune the functionality, but having a big ON/OFF doesnt seem a bad thing to me. Jack