From owner-cvs-all Sat Jan 9 01:53:20 1999 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id BAA05926 for cvs-all-outgoing; Sat, 9 Jan 1999 01:53:20 -0800 (PST) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from outmail.utsunomiya-u.ac.jp (outmail.utsunomiya-u.ac.jp [160.12.196.3]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id BAA05915; Sat, 9 Jan 1999 01:53:12 -0800 (PST) (envelope-from yokota@zodiac.mech.utsunomiya-u.ac.jp) Received: from zodiac.mech.utsunomiya-u.ac.jp (IDENT:TAMEz5gfdlzaGXDdpRipQtfrw8AyzM1Z@zodiac.mech.utsunomiya-u.ac.jp [160.12.42.1]) by outmail.utsunomiya-u.ac.jp (8.9.1/8.9.1) with ESMTP id SAA29316; Sat, 9 Jan 1999 18:52:41 +0900 (JST) Received: from zodiac.mech.utsunomiya-u.ac.jp (zodiac.mech.utsunomiya-u.ac.jp [160.12.42.1]) by zodiac.mech.utsunomiya-u.ac.jp (8.7.6+2.6Wbeta7/3.4W/zodiac-May96) with ESMTP id SAA08764; Sat, 9 Jan 1999 18:55:04 +0900 (JST) Message-Id: <199901090955.SAA08764@zodiac.mech.utsunomiya-u.ac.jp> To: Andrzej Bialecki cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, yokota@zodiac.mech.utsunomiya-u.ac.jp Subject: Re: cvs commit: src/sys/i386/i386 userconfig.c In-reply-to: Your message of "Fri, 08 Jan 1999 13:00:27 PST." <199901082100.NAA29107@freefall.freebsd.org> References: <199901082100.NAA29107@freefall.freebsd.org> Date: Sat, 09 Jan 1999 18:54:58 +0900 From: Kazutaka YOKOTA Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk Since INTOR_USERCONFIG was introduced a couple of months ago, I find the behavior of the UserConfig prompt odd, if not broken. Even if I don't enter UserConfig, I always got "config> quit" as below because userconfig.:getchar() returns "quit" when !RB_CONFIG. I think such echo shouldn't be showing when the user had no intention of running UserConfig in the first place. ----------------------------------------------------------------- CPU: Pentium Pro (686-class CPU) Origin = "GenuineIntel" Id = 0x619 Stepping=9 Features=0xfbff quit ~~~~~~~~~~~~ <- I didn't type this; getchar() automatically inserted it! avail memory = 62107648 (60652K bytes) Programming 24 pins in IOAPIC #0 ----------------------------------------------------------------- If I do enter UserConfig by giving -c option to the kernel, I got a banner "FreeBSD Kernel Configuration Utility...", but it shows AFTER the first "config>" prompt. This is slightly annoying. It should be printed BEFORE the "config>" prompt, shouldn't it? ----------------------------------------------------------------- CPU: Pentium Pro (686-class CPU) Origin = "GenuineIntel" Id = 0x619 Stepping=9 Features=0xfbff ~~~~~~~ <- unnecessary prompt FreeBSD Kernel Configuration Utility - Version 1.2 Type "help" for help or "visual" to go to the visual configuration interface (requires MGA/VGA display or serial terminal capable of displaying ANSI graphics). _ <- cursor is here!! ----------------------------------------------------------------- Kazu > Modified files: > sys/i386/i386 userconfig.c > Log: > Fix faulty logic in handling userconfig_script, INTRO_USERCONFIG and > RB_CONFIG. > > Now, the code should do the right thing in the following cases, when > kernel is compiled with INTRO_USERCONFIG: > > * when booted without userconfig_script and without RB_CONFIG, present > intro screen, and wait for user input. > > * when booted with userconfig_script and without RB_CONFIG, DON'T present > intro screen unless explicitly asked in userconfig_script, basing on > assumption that if a user loads userconfig_script, (s)he already > decided what parameters to configure. Proceed with booting. [...] To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message