From owner-freebsd-current@FreeBSD.ORG Fri Jan 23 21:29:53 2009 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E2683106564A for ; Fri, 23 Jan 2009 21:29:53 +0000 (UTC) (envelope-from lars@e.0x20.net) Received: from mail.0x20.net (mail.0x20.net [IPv6:2001:aa8:fffb::3]) by mx1.freebsd.org (Postfix) with ESMTP id 67CD68FC1C for ; Fri, 23 Jan 2009 21:29:53 +0000 (UTC) (envelope-from lars@e.0x20.net) Received: by mail.0x20.net (Postfix, from userid 1002) id 89BFA3A6A4; Fri, 23 Jan 2009 22:29:52 +0100 (CET) Date: Fri, 23 Jan 2009 22:29:52 +0100 From: Lars Engels To: Maksim Yevmenkin Message-ID: <20090123212952.GM60948@e.0x20.net> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="cf0hFtnykp6aONGL" Content-Disposition: inline In-Reply-To: X-Editor: VIM - Vi IMproved 7.1 X-Operation-System: FreeBSD 5.5-RELEASE-p19 User-Agent: mutt-ng/devel-r804 (FreeBSD) Cc: current@freebsd.org, Hans Petter Selasky Subject: Re: [PATCH] for ng_ubt2 stalled transfers X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Lars Engels List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Jan 2009 21:29:54 -0000 --cf0hFtnykp6aONGL Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 23, 2009 at 11:13:59AM -0800, Maksim Yevmenkin wrote: > On Fri, Jan 23, 2009 at 11:12 AM, Maksim Yevmenkin > wrote: > > Lars, > > > >> Maksim has made a lot of changes to the Bluetooth driver. Maybe he can= look > >> into it? > >> > >> This looks like a NULL-pointer access to me. > >> > >> Maksim: > >> > >> In the ubt_detach routine, make sure that: > >> > >> 0) No further commands are accepted from the Netgraph stack. > >> 1) You drain the task queue! > >> 2) You drain all USB transfers: "usb2_transfer_drain()" called unlocke= d. > >> 3) Set the "sc_node" to NULL. > > > > please try attached patch for ng_ubt2 that hopefully addresses some of > > the issues with stalled transfers. stalled transfers do not happen on > > my machine, so i can not test it. i briefly kicked the tires and made > > sure other things seems to work fine for me. >=20 > sorry, forgot to attach the patch :) >=20 > thanks, > max Thanks for the quick patch, but that did not help: ubt0: on usbus2 ubt0:ubt_bulk_read_callback:981: bulk-in transfer failed: USB_ERR_STALLED ubt0:ubt_intr_read_callback:834: interrupt transfer failed: USB_ERR_STALLED I also have another usb bluetooth stick which shows this on insertion: Jan 23 22:13:00 maggie kernel: usb2_alloc_device:1401: set address 2 failed= (ignored) Jan 23 22:13:00 maggie kernel: usb2_alloc_device:1436: getting device descr= iptor at addr 2 failed! Jan 23 22:13:01 maggie kernel: ugen0.2: at usbus0 Jan 23 22:13:01 maggie kernel: ubt1: on usbus0 Lars --cf0hFtnykp6aONGL Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (FreeBSD) iEYEARECAAYFAkl6NtAACgkQKc512sD3afjmhwCfZParmfRHKKE4MHR8mIwoVESH Ry4AoJXjjWDAPWbfl85aOk93kYgVZKjL =Ysgn -----END PGP SIGNATURE----- --cf0hFtnykp6aONGL--