From owner-cvs-all Tue May 14 6:24: 8 2002 Delivered-To: cvs-all@freebsd.org Received: from gate.qubesoft.com (gate.qubesoft.com [212.113.16.243]) by hub.freebsd.org (Postfix) with ESMTP id F0BF237B407; Tue, 14 May 2002 06:24:00 -0700 (PDT) Received: from bluebottle.qubesoft.com (bluebottle [192.168.1.2]) by gate.qubesoft.com (8.11.6/8.11.3) with ESMTP id g4EDNsZ57864; Tue, 14 May 2002 14:23:54 +0100 (BST) (envelope-from dfr@nlsystems.com) Received: from doug02.qubesoft.com (doug02.qubesoft.com [192.168.1.4]) by bluebottle.qubesoft.com (8.11.4/8.11.4) with ESMTP id g4EDNrS18144; Tue, 14 May 2002 14:23:54 +0100 (BST) (envelope-from dfr@nlsystems.com) Content-Type: text/plain; charset="iso-8859-1" From: Doug Rabson To: Luigi Rizzo , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet ip_fw.c Date: Tue, 14 May 2002 14:23:52 +0100 User-Agent: KMail/1.4.1 References: <200205122043.g4CKhod56192@freefall.freebsd.org> In-Reply-To: <200205122043.g4CKhod56192@freefall.freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-Id: <200205141423.52986.dfr@nlsystems.com> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sunday 12 May 2002 9:43 pm, Luigi Rizzo wrote: > luigi 2002/05/12 13:43:50 PDT > > Minor cleanup of the code, in some places moving the indentation to 4 > spaces because the code was becoming too deep. Eventually, in a > separate commit, I will move the whole file to 4 space indent. Please back this out. All kernel code should at least attempt to conform to style(9) and this change gratuitously moves away from that standard. I don't care about anyone's personal preferences here, we are trying to keep as much kernel code as possible working to a given style. If a function is indented so deeply that it can't be represented in 80 columns, then it seriously needs re-working, IMHO. By the way, for my own personal code, I don't particularly like the 8 space indent and I am also guilty of commiting code with 4 space indents (all of which is now re-formatted, I think). Again, this is not about personal preferences, its about project-wide style. -- Doug Rabson Mail: dfr@nlsystems.com Phone: +44 20 8348 6160 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message