From owner-svn-src-head@freebsd.org Tue Apr 26 18:38:01 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E1853B1C5ED for ; Tue, 26 Apr 2016 18:38:01 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from nm18-vm0.bullet.mail.bf1.yahoo.com (nm18-vm0.bullet.mail.bf1.yahoo.com [98.139.213.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9AC601304 for ; Tue, 26 Apr 2016 18:38:01 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1461695499; bh=1PaIPS+ojWsUlC53EZpJ8e7PTuk0JuK9iaLPU/d8Wwg=; h=Subject:To:References:From:Date:In-Reply-To:From:Subject; b=ouUeoN54/WU9F2OC5c4aS8uu+/RnaUVViddd2sko7pY71hIWCiKjh759qs1rrOWlSro9KNoqhN2g/1G65ylJUHqPx5plLAPS4anKTuWUIHs7u5/tlX9RLC70Mg+EeRss9abFuJ/r9ML5tgKUEXVAb/S8sjrvgnQjaoSqIcWVrBiTM1IFxTXXl7AlAhatNojgsVl+smBrVFkZBDyX+DyArn2klzTvoKtOLVxs1fsLEIBYh21tmF6qunmBm0O67c4yedFy7V0DNotn5YfDhgYOTStefPyok3wVC03EobZ24adcn4BOhHA35cGB1U2/eZ0ToKI2Jvjt6dLzkCQyfltklA== Received: from [98.139.215.140] by nm18.bullet.mail.bf1.yahoo.com with NNFMP; 26 Apr 2016 18:31:39 -0000 Received: from [68.142.230.74] by tm11.bullet.mail.bf1.yahoo.com with NNFMP; 26 Apr 2016 18:31:39 -0000 Received: from [127.0.0.1] by smtp231.mail.bf1.yahoo.com with NNFMP; 26 Apr 2016 18:31:39 -0000 X-Yahoo-Newman-Id: 800873.21409.bm@smtp231.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: wvYeUxgVM1liiScsGBMIvfS.dxqpZiQWG5LO1MqKTkkHqqt ylYNuQpNHVI2bJLjG.kV2euCiXP2F9sz7zql3eFz2kfJAv1vhryB2z2zpGil l7crSbw9krze5.xqNdfKMyfuCBImESzSRx8.aUT59cdYq97xhqHWjlhYyigw yJDc4Q4UfebPOlD_hH6t4AzjzLT3fXfNgnbua1L4BhmFMstsKWYw9QV3Ugiw wpd11LOl0_JY_YHOax7ZF8RQQIZE9eMk5wMMa.T47z8sd6GWyi4XKX97Btqd kLl8sslAGIR7Z.BJ2j.hQwhP_Gi4mUbW5Oya8asP_9hLtBjVzG5wKLAG61eE WalJbQUf9o6PWMUVr2ty0PjPpGxCAuKlgyRFAj8dpCWlwP4JYY6txXm6G34X Wa1bONQrbICsY_pb1XH6ITfaKIbTqIxyyZyR_etGLOJYwm1ercH8B7TaOEw_ HzFn52Q2Wmm_joXiQyu1NdzN_7nhXYzvgBPg0Arrt03KkUWaknBDRMEZ0TK5 3jAyFqc.tcU0E_UpCD0xVK7WtlOpIyIAc X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Subject: Re: svn commit: r298657 - head/sys/dev/sound/pci To: "Conrad E. Meyer" , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201604261820.u3QIKf92094942@repo.freebsd.org> From: Pedro Giffuni Message-ID: <95061c6a-ac25-3c0f-a1f0-1956477b2fc3@FreeBSD.org> Date: Tue, 26 Apr 2016 13:31:54 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <201604261820.u3QIKf92094942@repo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Apr 2016 18:38:02 -0000 On 04/26/16 13:20, Conrad E. Meyer wrote: > Author: cem > Date: Tue Apr 26 18:20:41 2016 > New Revision: 298657 > URL: https://svnweb.freebsd.org/changeset/base/298657 > > Log: > emu10kx: Don't iterate beyond array bounds > > Reported by: Coverity > CID: 1354978 > Sponsored by: EMC / Isilon Storage Division > > Modified: > head/sys/dev/sound/pci/emu10kx.c > > Modified: head/sys/dev/sound/pci/emu10kx.c > ============================================================================== > --- head/sys/dev/sound/pci/emu10kx.c Tue Apr 26 18:17:44 2016 (r298656) > +++ head/sys/dev/sound/pci/emu10kx.c Tue Apr 26 18:20:41 2016 (r298657) > @@ -587,7 +587,7 @@ emu_getcard(device_t dev) > } > } > > - for (i = 0; i < nitems(emu_cards); i++) { > + for (i = 0; i < nitems(emu_bad_cards); i++) { > if (device == emu_bad_cards[i].device) { > if (subdevice == emu_bad_cards[i].subdevice) { > thiscard = 0; > Hmm sadly interesting. This was not a script or an old bug; it was pilot error. Pointyhat: pfg Thanks!