From owner-cvs-src@FreeBSD.ORG Fri Apr 8 13:58:17 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5302616A4CF; Fri, 8 Apr 2005 13:58:17 +0000 (GMT) Received: from bgo1smout1.broadpark.no (bgo1smout1.broadpark.no [217.13.4.94]) by mx1.FreeBSD.org (Postfix) with ESMTP id C1B5D43D2F; Fri, 8 Apr 2005 13:58:16 +0000 (GMT) (envelope-from des@des.no) Received: from bgo1sminn1.broadpark.no ([217.13.4.93]) by bgo1smout1.broadpark.no (Sun Java System Messaging Server 6.1 HotFix 0.05 (built Oct 21 2004)) with ESMTP id <0IEM00ALORVRVK70@bgo1smout1.broadpark.no>; Fri, 08 Apr 2005 15:52:39 +0200 (CEST) Received: from dsa.des.no ([80.203.228.37]) by bgo1sminn1.broadpark.no (Sun Java System Messaging Server 6.1 HotFix 0.05 (built Oct 21 2004)) with ESMTP id <0IEM006CWS7D1ZA0@bgo1sminn1.broadpark.no>; Fri, 08 Apr 2005 15:59:37 +0200 (CEST) Received: by dsa.des.no (Pony Express, from userid 666) id 46BCCEBCB4; Fri, 08 Apr 2005 15:58:15 +0200 (CEST) Received: from xps.des.no (xps.des.no [10.0.0.12]) by dsa.des.no (Pony Express) with ESMTP id A8967EBC06; Fri, 08 Apr 2005 15:58:10 +0200 (CEST) Received: by xps.des.no (Postfix, from userid 1001) id 9BEE533C5A; Fri, 08 Apr 2005 15:58:10 +0200 (CEST) Date: Fri, 08 Apr 2005 15:58:10 +0200 From: des@des.no (=?iso-8859-1?q?Dag-Erling_Sm=F8rgrav?=) In-reply-to: <6715759dfc36ac3b48dc3efe8cfcd07d@FreeBSD.org> To: Jacques Vidrine Message-id: <8664yx2wwd.fsf@xps.des.no> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-transfer-encoding: quoted-printable X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on dsa.des.no References: <200504081119.j38BJoZf036618@repoman.freebsd.org> <6715759dfc36ac3b48dc3efe8cfcd07d@FreeBSD.org> User-Agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3 (berkeley-unix) X-Spam-Status: No, score=-2.8 required=5.0 tests=ALL_TRUSTED,AWL autolearn=disabled version=3.0.2 X-Spam-Level: cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/libexec/rexecd rexecd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Apr 2005 13:58:17 -0000 Jacques Vidrine writes: > Thanks for fixing, DES. Only, you have re-introduced some of the > bugs. You need to use getpwnam_r or copy the contents of the returned > struct passwd before continuing. Hmm, actually it should be sufficient to re-getpwnam() after the call to pam_setcred() in the child. There's nothing else that has the potential to screw up pwd. DES --=20 Dag-Erling Sm=F8rgrav - des@des.no