Date: Wed, 14 Oct 2020 19:01:04 +0000 From: Brooks Davis <brooks@freebsd.org> To: Jessica Clarke <jrtc27@freebsd.org> Cc: Mateusz Guzik <mjguzik@gmail.com>, Alex Richardson <arichardson@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r366697 - head/usr.bin/xinstall Message-ID: <20201014190104.GC3588@spindle.one-eyed-alien.net> In-Reply-To: <E0AD1261-DEB7-4049-AA54-9BBBE764E02F@freebsd.org> References: <202010141228.09ECSg0D023438@repo.freebsd.org> <CAGudoHE=4NxWKh1OfvNy_y4pBBcR4p=rL%2BQs5-GERzuW4WECjg@mail.gmail.com> <E0AD1261-DEB7-4049-AA54-9BBBE764E02F@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--XWOWbaMNXpFDWE00 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 14, 2020 at 02:40:42PM +0100, Jessica Clarke wrote: > On 14 Oct 2020, at 14:28, Mateusz Guzik <mjguzik@gmail.com> wrote: > >=20 > > This should use copy_file_range (also available on Linux). >=20 > I assume this is a bootstrap tool and hence the system OS and version > is relevant. macOS does not have copy_file_range, and FreeBSD only has > it in -CURRENT so that would break building on 11.x and 12.x. So any > use would need to be guarded by preprocessor checks (and there are > still actively-supported Linux distributions out there that are based > on too-old versions of the kernel and/or glibc to include it). >=20 > (FYI macOS's equivalent is copyfile(3)... maybe one day it will adopt > the copy_file_range(2) interface too) copyfile has different semantics, not the least of which is supporting file clones. Once ZFS grows file clone support it would be nice if install supported them as well. I'd love to only pay the inode cost for installed files when I'm just building a disk image. -- Brooks --XWOWbaMNXpFDWE00 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJfh0rvAAoJEKzQXbSebgfAOzEH/3P7QRd/784vNugHdf16EgEd jt1gIf7ouxCOV1Im2IDNInm6KxxD40vOiSEPihBpGpp51UFzEoekNyprtp0IiXmW gOY+SwF1I62xsZeRDrZRSHk9N/4XJsr9pSd3cyXWj8MSqBY0Y7SArPSs0Q18ayQa hhgtYHFSICDAm/eId0oHXpRdqT367Qc2fLIqgayqFZTApCnXmFBXUx1KY2UDnaUF Xw+e2f+lCMxczXOEZNRgYzIh/0eoUc9lUXgrNBYkCOXBNNEVWN5LoTI2qYnGrYWJ 39HxkEMPndAAc8N/yKAYYyhq1aApDGyqAj+ch1VP/y66QGFVszuY+9EKzes58hY= =0NAg -----END PGP SIGNATURE----- --XWOWbaMNXpFDWE00--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20201014190104.GC3588>