From owner-cvs-src@FreeBSD.ORG Mon Jan 15 19:39:27 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 8FC7316A407; Mon, 15 Jan 2007 19:39:27 +0000 (UTC) (envelope-from rrs@cisco.com) Received: from sj-iport-2.cisco.com (sj-iport-2-in.cisco.com [171.71.176.71]) by mx1.freebsd.org (Postfix) with ESMTP id 638B013C441; Mon, 15 Jan 2007 19:39:27 +0000 (UTC) (envelope-from rrs@cisco.com) Received: from sj-dkim-3.cisco.com ([171.71.179.195]) by sj-iport-2.cisco.com with ESMTP; 15 Jan 2007 11:10:33 -0800 X-IronPort-AV: i="4.13,191,1167638400"; d="scan'208"; a="356228224:sNHT47814044" Received: from sj-core-5.cisco.com (sj-core-5.cisco.com [171.71.177.238]) by sj-dkim-3.cisco.com (8.12.11/8.12.11) with ESMTP id l0FJAYmX024527; Mon, 15 Jan 2007 11:10:34 -0800 Received: from xbh-sjc-231.amer.cisco.com (xbh-sjc-231.cisco.com [128.107.191.100]) by sj-core-5.cisco.com (8.12.10/8.12.6) with ESMTP id l0FJAYUw004523; Mon, 15 Jan 2007 11:10:34 -0800 (PST) Received: from xfe-sjc-211.amer.cisco.com ([171.70.151.174]) by xbh-sjc-231.amer.cisco.com with Microsoft SMTPSVC(6.0.3790.1830); Mon, 15 Jan 2007 11:10:34 -0800 Received: from [127.0.0.1] ([171.68.225.134]) by xfe-sjc-211.amer.cisco.com with Microsoft SMTPSVC(6.0.3790.1830); Mon, 15 Jan 2007 11:10:33 -0800 Message-ID: <45ABD171.1050509@cisco.com> Date: Mon, 15 Jan 2007 14:09:37 -0500 From: Randall Stewart User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.8) Gecko/20061029 FreeBSD/i386 SeaMonkey/1.0.6 MIME-Version: 1.0 To: Max Laier References: <200701151506.l0FF6S6D022659@repoman.freebsd.org> <200701151933.39686.max@love2party.net> In-Reply-To: <200701151933.39686.max@love2party.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 15 Jan 2007 19:10:34.0050 (UTC) FILETIME=[D4F89220:01C738D8] DKIM-Signature: v=0.5; a=rsa-sha256; q=dns/txt; l=1128; t=1168888234; x=1169752234; c=relaxed/simple; s=sjdkim3002; h=Content-Type:From:Subject:Content-Transfer-Encoding:MIME-Version; d=cisco.com; i=rrs@cisco.com; z=From:=20Randall=20Stewart=20 |Subject:=20Re=3A=20cvs=20commit=3A=20src/sys/kern=20kern_subr.c=20src/sy s/sys=20systm.h=20src/share/man/man9=0A=20Makefile=20hashinit.9 |Sender:=20; bh=6ofM8NW6YdnyusjkRi8j3qez6MA58JEru2VG/174iC8=; b=n7ea5EAhv/xaDNkZW82FDXlrOnVjeDW1mHEs873UAJvJAqSFW3ZHarX75smGEAaKDJhxRM1Y eTJEIkt7eljsBKdHBipXHY8e6ZP37RmDuxNQ8g8BmxQsbMUo54LcL5xA; Authentication-Results: sj-dkim-3; header.From=rrs@cisco.com; dkim=pass (sig from cisco.com/sjdkim3002 verified; ); Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_subr.c src/sys/sys systm.h src/share/man/man9 Makefile hashinit.9 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jan 2007 19:39:27 -0000 Max Laier wrote: > On Monday 15 January 2007 16:06, Randall Stewart wrote: > This breaks the tinderbox: >> /src/sys/kern/kern_subr.c: In function `hashinit_flags': >> /src/sys/kern/kern_subr.c:375: warning: suggest parentheses around >> comparison in operand of | *** Error code 1 Yeah, it was the one thing that Robert had me add amongst some other spacing issues. And of course I had already did my make universe on the old version :-0 I have a patch for it.. but am waiting for approval from George :-) > > and why are we useing new flags, btw? Can't we just pass down the normal > malloc flags? I seem to remember that we do that in a couple of places > already. > Well... I was game to either method.. I think the general thought was that there may be OTHER non-memory flags that we direct at hash-init someday.. and having them not locked to memory was a good thing.. Robert might care to comment on this one .. of course it can always be changed to be just the memory flags too :-) R -- Randall Stewart NSSTG - Cisco Systems Inc. 803-345-0369 803-317-4952 (cell)