Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 21 May 1999 04:37:23 +0700 (NSS)
From:      Ustimenko Semen <semen@iclub.nsu.ru>
To:        amagai@nue.org
Cc:        freebsd-bugs@FreeBSD.ORG
Subject:   Re: pending/11754: tx driver, SIOCGIFADDR ioctl does not work
Message-ID:  <Pine.BSF.4.05.9905210433260.57827-100000@iclub.nsu.ru>
In-Reply-To: <199905200418.NAA10350@may.nue.org>

next in thread | previous in thread | raw e-mail | index | archive | help


On Thu, 20 May 1999 amagai@nue.org wrote:

> My pr 11754 was not accepted by gnats, what's happened...
> 
> By the way, SIOCGIFADDR ioctl does not work on tx (SMC chip) network
> driver.  The SIOCGIFADDR ioctl [src/pci/if_tx.c, epic_ifioctl]
> invokes ether_ioctl() [src/net/if_ethersubr.c].  Here, MAC address
> is copied out, as follows.
> 
>  bcopy(((struct arpcom *)ifp->if_softc)->ac_enaddr,
>        (caddr_t) sa->sa_data, ETHER_ADDR_LEN);
> 
> So, "struct arpcom arpcom" must be a first element of softc structure.
> 
> /*	$OpenBSD: if_txvar.h,v 1.3 1998/10/10 04:30:09 jason Exp $	*/
> /*      $Id: if_txvar.h,v 1.1.4.1 1999/04/23 05:47:53 semenu Exp $ */
> 
> ================================================================
> --- if_txvar.h'	Tue May 18 15:40:12 1999
> +++ if_txvar.h	Tue May 18 15:41:15 1999
> @@ -329,6 +329,7 @@
>  	bus_space_tag_t		sc_st;
>  	bus_space_handle_t	sc_sh;
>  #else /* __FreeBSD__ */
> +	struct arpcom		arpcom;
>  #if defined(EPIC_USEIOSPACE)
>  	u_int32_t		iobase;
>  #else
> @@ -338,7 +339,6 @@
>  #if !defined(EPIC_NOIFMEDIA)
>  	struct ifmedia 		ifmedia;
>  #endif
> -	struct arpcom		arpcom;
>  	u_int32_t		unit;
>  	struct epic_rx_buffer	rx_buffer[RX_RING_SIZE];
>  	struct epic_tx_buffer	tx_buffer[TX_RING_SIZE];
> ================================================================
> 

All right, thank you!

Except you have removed arpcom from OpenBSDbranch...
I'll commit correct patch soon.

Thank you.



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.05.9905210433260.57827-100000>