From owner-p4-projects@FreeBSD.ORG Wed May 9 10:21:14 2007 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 07A4016A403; Wed, 9 May 2007 10:21:14 +0000 (UTC) X-Original-To: perforce@FreeBSD.org Delivered-To: perforce@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 8B74016A400; Wed, 9 May 2007 10:21:13 +0000 (UTC) (envelope-from fli@shapeshifter.se) Received: from mx1.h3q.net (mx1.h3q.net [212.37.5.30]) by mx1.freebsd.org (Postfix) with ESMTP id 45C3F13C45A; Wed, 9 May 2007 10:21:13 +0000 (UTC) (envelope-from fli@shapeshifter.se) Received: from [130.237.226.17] (grey-03.nada.kth.se [130.237.226.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: fli@shapeshifter.se) by mx1.h3q.net (Postfix) with ESMTP id 13A3978C20; Wed, 9 May 2007 11:52:33 +0200 (CEST) Message-ID: <464199D9.7020908@shapeshifter.se> Date: Wed, 09 May 2007 11:52:25 +0200 From: Fredrik Lindberg User-Agent: Thunderbird 1.5.0.10 (X11/20070303) MIME-Version: 1.0 To: Robert Watson References: <200705082229.l48MTrbh069129@repoman.freebsd.org> <20070509070626.GA41419@freebsd.org> <4641818B.4030507@FreeBSD.org> <20070509103404.D71759@fledge.watson.org> In-Reply-To: <20070509103404.D71759@fledge.watson.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Roman Divacky , Perforce Change Reviews , Fredrik Lindberg Subject: Re: PERFORCE change 119527 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2007 10:21:14 -0000 Robert Watson wrote: > > On Wed, 9 May 2007, Fredrik Lindberg wrote: > >> Roman Divacky wrote: >>> On Tue, May 08, 2007 at 10:29:53PM +0000, Fredrik Lindberg wrote: >>>> http://perforce.freebsd.org/chv.cgi?CH=119527 >>>> >>>> Change 119527 by fli@fli_genesis on 2007/05/08 22:29:14 >>>> >>>> Add data structures needed by the stack. >>>> A Double-linked list and a hash table. >>> >>> what about sys/queue.h ? it provides various abstract data types >>> including double-linked list >> >> Yes, I know it does provide that, and I've used it a lot in the past. >> A while ago I needed a linked list for another project where I needed >> to be independent of FreeBSD. So I rolled my own (with a similar api) >> and I've used it ever since. (It can be used both as a stack and queue). >> >> It's not exactly rocket-science and it does increase portability since >> this is a userland application. If there aren't any major objections >> or other selling points in favor for sys/queue.h (in a userland >> application!) I'm just going to leave it as it is. > > FYI, slightly stale versions of queue.h are shipped with both Linux and > Mac OS X, so they are actually relatively portable. Some of the more > recent TAILQ macros, etc, aren't available there, so I recently changed > from using the OS-native queue.h in OpenBSM to a FreeBSD version I ship > to use on those platforms. > Ok, I'll take a look at the various queue.h shipped with the major BSDs, and see if I can find a common subset that suits my needs (without too many compromises) and based on the findings I'll reconsider my choice. Fredrik Lindberg