From owner-freebsd-hackers@FreeBSD.ORG  Mon Oct 29 10:15:43 2012
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 4637C751;
 Mon, 29 Oct 2012 10:15:43 +0000 (UTC) (envelope-from zec@fer.hr)
Received: from mail.zvne.fer.hr (mail.zvne.fer.hr [161.53.66.5])
 by mx1.freebsd.org (Postfix) with ESMTP id BAB8E8FC16;
 Mon, 29 Oct 2012 10:15:42 +0000 (UTC)
Received: from munja.zvne.fer.hr (161.53.66.248) by mail.zvne.fer.hr
 (161.53.66.5) with Microsoft SMTP Server id 14.2.318.4; Mon, 29 Oct 2012
 11:15:35 +0100
Received: from sluga.fer.hr ([161.53.66.244]) by munja.zvne.fer.hr with
 Microsoft SMTPSVC(6.0.3790.4675);	 Mon, 29 Oct 2012 11:15:35 +0100
Received: from localhost ([161.53.19.8]) by sluga.fer.hr over TLS secured
 channel with Microsoft SMTPSVC(6.0.3790.4675);	 Mon, 29 Oct 2012 11:15:34
 +0100
From: Marko Zec <zec@fer.hr>
To: Adrian Chadd <adrian@freebsd.org>
Subject: Re: VIMAGE crashes on 9.x with hotplug net80211 devices
Date: Mon, 29 Oct 2012 11:15:23 +0100
User-Agent: KMail/1.9.10
References: <CAJ-VmomchJZ7GUKrAjmmyBXDw-6H6O5fAxT_tfAFfhU=HknG1g@mail.gmail.com>
 <CAJ-VmomnCFhwzs+6FVkFmHscnGop7NHxK3pzddStjD3QSMb+2g@mail.gmail.com>
 <CAJ-VmokdwGQGYG4pN6gL=C90VAL2rETgzRH+0diiD9w=_HVLoQ@mail.gmail.com>
In-Reply-To: <CAJ-VmokdwGQGYG4pN6gL=C90VAL2rETgzRH+0diiD9w=_HVLoQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-ID: <201210291115.23845.zec@fer.hr>
X-OriginalArrivalTime: 29 Oct 2012 10:15:34.0961 (UTC)
 FILETIME=[55AFCA10:01CDB5BE]
Cc: freebsd-net@freebsd.org, Hans Petter Selasky <hselasky@freebsd.org>,
 freebsd-hackers@freebsd.org
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
 <freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
 <mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 29 Oct 2012 10:15:43 -0000

On Sunday 28 October 2012 19:47:20 Adrian Chadd wrote:
> ping?
>
> Marko - would you be willing to add the if_free() vnet context setup into
> -HEAD?

Feel free to do it - though I'd suggest to use the CURVNET_SET_QUIET() 
variant there, to reduce the console spam with VNET_DEBUG.

Marko


Index: if.c
===================================================================
--- if.c        (revision 242304)
+++ if.c        (working copy)
@@ -513,7 +513,9 @@
 
        if (!refcount_release(&ifp->if_refcount))
                return;
+       CURVNET_SET_QUIET(ifp->if_vnet);
        if_free_internal(ifp);
+       CURVNET_RESTORE();
 }
 
 /*