From owner-cvs-all Sun Apr 8 12:13:20 2001 Delivered-To: cvs-all@freebsd.org Received: from tantalum.btinternet.com (tantalum.btinternet.com [194.73.73.80]) by hub.freebsd.org (Postfix) with ESMTP id C255237B423; Sun, 8 Apr 2001 12:13:12 -0700 (PDT) (envelope-from oh@btinternet.com) Received: from [213.122.242.57] (helo=adelie.btinternet.com) by tantalum.btinternet.com with esmtp (Exim 3.03 #83) id 14mKcZ-0003TP-00; Sun, 08 Apr 2001 20:13:11 +0100 Received: from btinternet.com (localhost [127.0.0.1]) by adelie.btinternet.com (8.11.3/8.11.3) with ESMTP id f38JD6V01127; Sun, 8 Apr 2001 20:13:06 +0100 (BST) (envelope-from oh@btinternet.com) Message-Id: <200104081913.f38JD6V01127@adelie.btinternet.com> To: Graywane , "David O'Brien" Cc: cvs-committers@freebsd.org, cvs-all@freebsd.org References: <200104071416.f37EGX307097@freefall.freebsd.org> <3ACF75AD.C4DD23AE@urx.com> <20010407202934.A10520@dragon.nuxi.com> From: Orion Hodson Reply-To: Orion Hodson Subject: Re: cvs commit: src/sys/dev/sound/pci cmi.c Date: Sun, 08 Apr 2001 20:13:06 +0100 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sat, Apr 07, 2001 at 08:29:35PM -0700, David O'Brien wrote: > > > > Modified files: (Branch: RELENG_4) > > > > sys/dev/sound/pci cmi.c > > > > If a commit was going to do something like this; I expect them to do a > > `cvsup' and `make world' + kernel build from _virgin_ sources. By > > virgin, I mean `cd /usr && rm -rf src && cvs co src -rRELENG_4'. > > A simple > > config ... > make depend > make > > on just the kernel source would also have found the error in just a few > minutes. Odd that no one actually compiles code before checking it in. Everybody, About the cmi driver breaking RELENG_4: I forgot to commit the corresponding header file changes. For whatever reason I was away for 27 hours and lots of builds got broken. This was a stupid thing to do and irritated lots of good people. Sorry. The header has now been MFC'ed, I'll endevour not to repeat this type of mistake in future. Kind Regards - Orion To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message