From owner-freebsd-bugs@FreeBSD.ORG Fri Dec 24 19:00:45 2004 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 61CE316A4CE for ; Fri, 24 Dec 2004 19:00:45 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2441443D41 for ; Fri, 24 Dec 2004 19:00:45 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.1/8.13.1) with ESMTP id iBOJ0ihw066165 for ; Fri, 24 Dec 2004 19:00:45 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.1/8.13.1/Submit) id iBOJ0iEb066164; Fri, 24 Dec 2004 19:00:44 GMT (envelope-from gnats) Resent-Date: Fri, 24 Dec 2004 19:00:44 GMT Resent-Message-Id: <200412241900.iBOJ0iEb066164@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Jon Simola Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D8A6F16A4CE for ; Fri, 24 Dec 2004 18:52:24 +0000 (GMT) Received: from www.freebsd.org (www.freebsd.org [216.136.204.117]) by mx1.FreeBSD.org (Postfix) with ESMTP id C1CA943D2F for ; Fri, 24 Dec 2004 18:52:24 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.13.1/8.13.1) with ESMTP id iBOIqOxv002607 for ; Fri, 24 Dec 2004 18:52:24 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.13.1/8.13.1/Submit) id iBOIqO2I002606; Fri, 24 Dec 2004 18:52:24 GMT (envelope-from nobody) Message-Id: <200412241852.iBOIqO2I002606@www.freebsd.org> Date: Fri, 24 Dec 2004 18:52:24 GMT From: Jon Simola To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-2.3 Subject: misc/75471: Inconsistent MAC formatting by /usr/sbin/arp on vlan pseudo interfaces X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Dec 2004 19:00:45 -0000 >Number: 75471 >Category: misc >Synopsis: Inconsistent MAC formatting by /usr/sbin/arp on vlan pseudo interfaces >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Dec 24 19:00:44 GMT 2004 >Closed-Date: >Last-Modified: >Originator: Jon Simola >Release: 5.3-STABLE >Organization: >Environment: FreeBSD tycho.abccomm.com 5.3-STABLE FreeBSD 5.3-STABLE #1: Wed Dec 22 17:11:02 PST 2004 jon@tycho.abccomm.com:/usr/obj/usr/src/sys/CARP i386 >Description: Sample output from my Vlan router #/usr/sbin/arp -an ? (204.239.167.99) at 00:90:27:76:a9:9c on em0 [ethernet] ? (204.239.167.248) at 00:30:48:72:36:24 on em0 [ethernet] <...> ? (208.181.67.228) at 0.30.ab.4.43.4 on vlan100 [vlan] ? (208.181.68.97) at 0.1.2.3.4.5 on vlan100 [vlan] I expected zero-filled and colon seperated MACs, the non filled and dot seperated MACs on the vlan interfaces are suprising. >How-To-Repeat: /usr/sbin/arp on any vlan pseudointerface. >Fix: --- usr.sbin/arp/arp.c.orig Fri Dec 24 11:45:11 2004 +++ usr.sbin/arp/arp.c Fri Dec 24 11:53:04 2004 @@ -523,7 +523,7 @@ } printf("%s (%s) at ", host, inet_ntoa(addr->sin_addr)); if (sdl->sdl_alen) { - if (sdl->sdl_type == IFT_ETHER && + if ((sdl->sdl_type == IFT_ETHER || sdl->sdl_type == IFT_L2VLAN) && sdl->sdl_alen == ETHER_ADDR_LEN) printf("%s", ether_ntoa((struct ether_addr *)LLADDR(sdl))); else { >Release-Note: >Audit-Trail: >Unformatted: