From owner-svn-src-all@FreeBSD.ORG Tue Sep 9 14:26:12 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A6F498E1; Tue, 9 Sep 2014 14:26:12 +0000 (UTC) Received: from smtp.dlink.ua (smtp.dlink.ua [193.138.187.146]) by mx1.freebsd.org (Postfix) with ESMTP id 5FD9E191; Tue, 9 Sep 2014 14:26:12 +0000 (UTC) Received: from terran (unknown [192.168.99.1]) (Authenticated sender: ray) by smtp.dlink.ua (Postfix) with ESMTPSA id B1443C4934; Tue, 9 Sep 2014 17:26:04 +0300 (EEST) Date: Tue, 9 Sep 2014 17:27:28 +0300 From: Aleksandr Rybalko To: Bruce Evans Subject: Re: svn commit: r269474 - in head: share/man/man4 sys/dev/vt Message-Id: <20140909172728.2eb5cfc5d7159f60896e1a0a@ddteam.net> In-Reply-To: <20140812121718.U1185@besplex.bde.org> References: <53de340e.52ce.7073778e@svn.freebsd.org> <20140805091730.N2827@besplex.bde.org> <201408111315.16939.jhb@freebsd.org> <20140812121718.U1185@besplex.bde.org> X-Mailer: Sylpheed 3.4.2 (GTK+ 2.24.22; amd64-portbld-freebsd9.1) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, Aleksandr Rybalko , src-committers@freebsd.org, svn-src-all@freebsd.org, John Baldwin X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Sep 2014 14:26:12 -0000 On Tue, 12 Aug 2014 13:17:55 +1000 (EST) Bruce Evans wrote: > On Mon, 11 Aug 2014, John Baldwin wrote: > > > On Monday, August 04, 2014 8:03:58 pm Bruce Evans wrote: > >> On Mon, 4 Aug 2014, John Baldwin wrote: > >>> I realize the API uses 'SPCL' as an abbreviation, but for user-facing things like a sysctl and tunable, I think it might be better to spell it out as > > "specialkeys" instead? > >> > >> It is a bad name, and also gratuitously different from syscons where the > >> names are: > >> > >> hw.syscons.kbd_reboot > >> hw.syscons.kbd_debug > >> hw.syscons.sc_no_suspend_vtswitch > > > > I would prefer individual nodes for vt along these lines as I think it is > > clearer to the user ("what exactly constitutes a special key?") > > But rename them a bit so it is clearer that they give limited access > control. The sysctl -d descriptions are no better about this: > > % hw.syscons.kbd_reboot: enable keyboard reboot > % hw.syscons.kbd_debug: enable keyboard debug > % hw.syscons.sc_no_suspend_vtswitch: Disable VT switch before suspend. > > These also have some style bugs ("enable" is not capitalized; the last > description is terminated). > > The option name SC_DISABLE_KDBKEY is better. It more clearly controls > a key, not debugging. The option name SC_DISABLE_REBOOT is no better. > > Bruce Hello John, Bruce and other hackers! I did revert r269474, but not commit yet new version. Instead, I've put new version into phabricator. Please look it here https://reviews.freebsd.org/D747. Thanks a lot for your hints/comments. And sorry for long delay. WBW -- Aleksandr Rybalko