From owner-dev-commits-src-all@freebsd.org Mon Aug 9 16:06:26 2021 Return-Path: <owner-dev-commits-src-all@freebsd.org> Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2123E657281; Mon, 9 Aug 2021 16:06:26 +0000 (UTC) (envelope-from garga.bsd@gmail.com) Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Gk1D16vGSz4njt; Mon, 9 Aug 2021 16:06:25 +0000 (UTC) (envelope-from garga.bsd@gmail.com) Received: by mail-pl1-x631.google.com with SMTP id l11so5254430plk.6; Mon, 09 Aug 2021 09:06:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:organization:in-reply-to :content-transfer-encoding; bh=tsPuafF3Ii61aa2V4vYp5hGTQeND9uPPeqDjKRT4QZM=; b=tBeBZpG76oG3otiu1TSxfBoX8uOnku1Ee4rJh+OhYw5BI4DF2HT0CnMbtglTszShbK AB5EY65B1kWq3ekud7cjoNNyoz3PnyRyb14RjnpZgaxEG4ANtF4z24kwnGvkRBSDG7Bf dFwikfXQzaTzUO/tF6ayngLw+BI447ly0e/n9S2ShkZ2PJkgCeK6P7nyU/dly5m4GnsT 7gxtP0tPUqJNvXoSDK/8eQ8HbK0S7PR5JA9x9hNBLSGUmySAQzYdYbZTlBpfEaRA4S1V XF0n6g+fS+x/AeXkMo57ZaRfKa8Txkh5f0q6wS8bR++fsuyaxJy3VUKMHMfM6qkrZKb9 R6nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:references:from:organization :in-reply-to:content-transfer-encoding; bh=tsPuafF3Ii61aa2V4vYp5hGTQeND9uPPeqDjKRT4QZM=; b=Nrd5/IRdAtXy3biGeQIa3qyKoCeE8LV7khomeE2YmmpNPJZkSJ2uxVjXVDSQvFrBhh a7zDzLe5iFgnm9ct2oxyfIyyqXbUkoXPKNNJ8eYFw6TUIzuvdIx2hlX8ZeXINUeGN6GV FdQLmjW1/T4yEQ7GJAnS1pAenI+uqen6IvPIDMsiQjnczCmAViVSFnjGiTHCe16MliZj nuHSjv0RlDZhKw5tr2uauF7seelSJhqEjxopHgPN1I6x4VAVj5rMJ8GLW3mLAN81PDmJ amsQXt/hTtOCYbyHLHR3lydAPbGOcOdwglblwdpa5Koc1PvKzQ95SuFNW4KTGfO56EdW BSWw== X-Gm-Message-State: AOAM530EfrothDEPwgJTuKwk8w75mTuuz18trvQrJSmHeLQGupgP/gPW j51JKBVyX1QOBsOH02pevQ9A+t3eZIg= X-Google-Smtp-Source: ABdhPJw9diXgz946thcsEE3WyIvOPprW8Mg6Ki1Ec4B1MacFRbIXfjBgi23hQ+VP7L+vPMFMDvOuUQ== X-Received: by 2002:a17:90a:4e4e:: with SMTP id t14mr26654854pjl.8.1628525184480; Mon, 09 Aug 2021 09:06:24 -0700 (PDT) Received: from [172.21.4.113] (200-12-2-199.rev.tribenet.com.br. [200.12.2.199]) by smtp.gmail.com with UTF8SMTPSA id g23sm21625986pfk.148.2021.08.09.09.06.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Aug 2021 09:06:23 -0700 (PDT) Sender: Renato Botelho <garga.bsd@gmail.com> Message-ID: <7e14b7b6-5ed5-d8fa-8114-effb3c475f09@FreeBSD.org> Date: Mon, 9 Aug 2021 13:06:20 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.0 Subject: Re: git: fd17ea8c1849 - main - release: make pkg installs more robust Content-Language: en-US To: Brad Davis <brd@FreeBSD.org>, src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202108091555.179FtIxN054742@gitrepo.freebsd.org> From: Renato Botelho <garga@FreeBSD.org> Organization: FreeBSD In-Reply-To: <202108091555.179FtIxN054742@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4Gk1D16vGSz4njt X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository <dev-commits-src-all.freebsd.org> List-Unsubscribe: <https://lists.freebsd.org/mailman/options/dev-commits-src-all>, <mailto:dev-commits-src-all-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/dev-commits-src-all/> List-Post: <mailto:dev-commits-src-all@freebsd.org> List-Help: <mailto:dev-commits-src-all-request@freebsd.org?subject=help> List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/dev-commits-src-all>, <mailto:dev-commits-src-all-request@freebsd.org?subject=subscribe> X-List-Received-Date: Mon, 09 Aug 2021 16:06:26 -0000 On 09/08/21 12:55, Brad Davis wrote: > The branch main has been updated by brd: > > URL: https://cgit.FreeBSD.org/src/commit/?id=fd17ea8c1849039c436f7192ca407db70561df03 > > commit fd17ea8c1849039c436f7192ca407db70561df03 > Author: Brad Davis <brd@FreeBSD.org> > AuthorDate: 2021-08-09 15:47:03 +0000 > Commit: Brad Davis <brd@FreeBSD.org> > CommitDate: 2021-08-09 15:54:08 +0000 > > release: make pkg installs more robust > > Currently pkg(8) will fail to install any package if one is missing, so > make this a loop to prevent one missing package from preventing the rest > from installing. Seen building an AWS AMI for aarch64 on main and > ebsnvme-id is not available in the repo at the moment. > > Approved by: gjb > MFC after: 1 week > Sponsored by: Rubicon Communications, LLC ("Netgate") > --- > release/tools/vmimage.subr | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/release/tools/vmimage.subr b/release/tools/vmimage.subr > index 6e0c1ea633e2..0e7edb97854a 100644 > --- a/release/tools/vmimage.subr > +++ b/release/tools/vmimage.subr > @@ -131,8 +131,10 @@ vm_extra_install_packages() { > mount -t devfs devfs ${DESTDIR}/dev > chroot ${DESTDIR} ${EMULATOR} env ASSUME_ALWAYS_YES=yes \ > /usr/sbin/pkg bootstrap -y > - chroot ${DESTDIR} ${EMULATOR} env ASSUME_ALWAYS_YES=yes \ > - /usr/sbin/pkg install -y ${VM_EXTRA_PACKAGES} > + for p in ${ASSUME_ALWAYS_YES}; do I guess you meant to use ${VM_EXTRA_PACKAGES} here, no? -- Renato Botelho