From owner-freebsd-current@FreeBSD.ORG  Fri Sep 17 15:39:21 2010
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B77601065693;
	Fri, 17 Sep 2010 15:39:21 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id 763828FC20;
	Fri, 17 Sep 2010 15:39:21 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id o8HFa3RE019284;
	Fri, 17 Sep 2010 09:36:03 -0600 (MDT) (envelope-from imp@bsdimp.com)
Date: Fri, 17 Sep 2010 09:36:13 -0600 (MDT)
Message-Id: <20100917.093613.490009667275365136.imp@bsdimp.com>
To: joel@FreeBSD.org
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <20100917055953.GF1036@pluto.vnode.local>
References: <20100915063233.GE1036@pluto.vnode.local>
	<201009160828.35520.jhb@freebsd.org>
	<20100917055953.GF1036@pluto.vnode.local>
X-Mailer: Mew version 6.3 on Emacs 22.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: freebsd-current@FreeBSD.org, jhb@FreeBSD.org
Subject: Re: Multiple hpet messages during boot
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Sep 2010 15:39:21 -0000

In message: <20100917055953.GF1036@pluto.vnode.local>
            Joel Dahl <joel@FreeBSD.ORG> writes:
: On 16-09-2010  8:28, John Baldwin wrote:
: > On Wednesday, September 15, 2010 2:32:33 am Joel Dahl wrote:
: > > I noticed this during boot (HEAD from yesterday):
: > > 
: > > hpet0: [FILTER]
: > > hpet0: [FILTER]
: > > hpet0: [FILTER]
: > > hpet0: [FILTER]
: > > hpet0: [FILTER]
: > > hpet0: [FILTER]
: > > hpet0: [FILTER]
: > > hpet0: [FILTER]
: > > 
: > > Is it really necessary to print this 8 times?
: > 
: > I'd actually like to remove the interrupt messages that say '[FILTER]' or 
: > '[GIANT]', etc.  I think in general they only add clutter.
: 
: Definitely agreed.  Go for it.

so is there support for the following:

Index: subr_bus.c
===================================================================
--- subr_bus.c	(revision 212791)
+++ subr_bus.c	(working copy)
@@ -3996,9 +3996,11 @@
 	    arg, cookiep);
 	if (error != 0)
 		return (error);
+	if (bootverbose == 0)
+		return (0);
 	if (handler != NULL && !(flags & INTR_MPSAFE))
 		device_printf(dev, "[GIANT-LOCKED]\n");
-	if (bootverbose && (flags & INTR_MPSAFE))
+	if (flags & INTR_MPSAFE)
 		device_printf(dev, "[MPSAFE]\n");
 	if (filter != NULL) {
 		if (handler == NULL)


Warner