Date: Sun, 6 Nov 2022 22:40:56 -0800 From: Mark Millard <marklmi@yahoo.com> To: "lwhsu@freebsd.org" <lwhsu@FreeBSD.org>, rpokala@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: 3bf53c4c8f53 - main - release(7): Enable zpoolupgrade rc script in ZFS based VM images Message-ID: <11759F16-631B-468B-A6A0-1613094F076B@yahoo.com> References: <11759F16-631B-468B-A6A0-1613094F076B.ref@yahoo.com>
next in thread | previous in thread | raw e-mail | index | archive | help
From: Ravi Pokala <rpokala_at_freebsd.org> wrote on Date: Mon, 07 Nov 2022 05:33:05 UTC : >=20 > Hi Li-Wen, >=20 > If I'm reading this (and 72a1cb05cd23) correctly, this will run `zpool = upgrade' on the "zroot" pool on every boot. That's fine for the first = time a VM image is used, since presumably the root pool and the = bootloader were generated from the same sources. But if the root pool is = subsequently upgraded by the running VM, don't we need to make sure the = bootloader is also upgraded? Otherwise, don't we run into the = possibility of this new `zpoolupgrade' script enabling features which = are not supported by the bootloader? >=20 > There should be some mechanism for upgrading the bootloader, or else = something else that runs on the first boot from the VM image should = disable `zpoolupgrade' so it is only run the first time. There is also the issue of what of folks that want to maintain pools in a state compatible with a RELEASE or with a STABLE (the timing for a STABLE getting a zpool feature addition need not match main's addition of the feature), including possibly compatibility with an older loader involved. This could be an issue even for the first time a VM is booted. A means of disabling the upgrade or controlling its details might be needed. For example, someone might want to use just what is indicated in: /usr/share/zfs/compatibility.d/openzfs-2.1-freebsd (avoiding more recent additions, some of which might still be in development until openzfs-2.2 is final). > Thanks, >=20 > Ravi (rpokala@) >=20 > =EF=BB=BF-----Original Message----- > From: <owner-src-committers@freebsd.org> on behalf of Li-Wen Hsu = <lwhsu@FreeBSD.org> > Date: 2022-11-06, Sunday at 19:50 > To: <src-committers@FreeBSD.org>, <dev-commits-src-all@FreeBSD.org>, = <dev-commits-src-main@FreeBSD.org> > Subject: git: 3bf53c4c8f53 - main - release(7): Enable zpoolupgrade rc = script in ZFS based VM images >=20 > The branch main has been updated by lwhsu: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D3bf53c4c8f53b1f19313e9c31415c7ee= e830cdc0 >=20 > commit 3bf53c4c8f53b1f19313e9c31415c7eee830cdc0 > Author: Li-Wen Hsu <lwhsu@FreeBSD.org> > AuthorDate: 2022-11-07 03:47:33 +0000 > Commit: Li-Wen Hsu <lwhsu@FreeBSD.org> > CommitDate: 2022-11-07 03:47:33 +0000 >=20 > release(7): Enable zpoolupgrade rc script in ZFS based VM images >=20 > This will enable VM access to all ZFS feature automatically, only on a > newly installed or provisioned VM or cloud instance. >=20 > Reviewed by: markj > Sponsored by: The FreeBSD Foundation > Differential Revision: https://reviews.freebsd.org/D37283 =3D=3D=3D Mark Millard marklmi at yahoo.com
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?11759F16-631B-468B-A6A0-1613094F076B>