From owner-freebsd-arch@FreeBSD.ORG Tue Dec 12 15:00:49 2006 Return-Path: X-Original-To: arch@freebsd.org Delivered-To: freebsd-arch@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5C31516A4FE for ; Tue, 12 Dec 2006 15:00:49 +0000 (UTC) (envelope-from stefan@fafoe.narf.at) Received: from viefep20-int.chello.at (viefep16-int.chello.at [213.46.255.18]) by mx1.FreeBSD.org (Postfix) with ESMTP id 396A643CA5 for ; Tue, 12 Dec 2006 14:56:40 +0000 (GMT) (envelope-from stefan@fafoe.narf.at) Received: from lizard.fafoe.narf.at ([213.47.85.26]) by viefep20-int.chello.at (InterMail vM.6.01.05.04 201-2131-123-105-20051025) with ESMTP id <20061212145739.FHOI21913.viefep20-int.chello.at@lizard.fafoe.narf.at>; Tue, 12 Dec 2006 15:57:39 +0100 Received: by lizard.fafoe.narf.at (Postfix, from userid 1001) id 0FEACBB80; Tue, 12 Dec 2006 15:57:39 +0100 (CET) Date: Tue, 12 Dec 2006 15:57:39 +0100 From: Stefan Farfeleder To: Luigi Rizzo Message-ID: <20061212145738.GC915@lizard.fafoe.narf.at> References: <200612081036.kB8AakMD029277@repoman.freebsd.org> <20061212131333.GU54209@cicely12.cicely.de> <20061212055756.A61182@xorpc.icir.org> <20061212141759.GZ54209@cicely12.cicely.de> <20061212062445.A61903@xorpc.icir.org> <20061212143113.GA54209@cicely12.cicely.de> <20061212064246.A62035@xorpc.icir.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20061212064246.A62035@xorpc.icir.org> User-Agent: Mutt/1.5.13 (2006-08-11) Cc: arch@freebsd.org Subject: Re: cvs commit: src/sys/net if_ethersubr.c X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Dec 2006 15:00:49 -0000 On Tue, Dec 12, 2006 at 06:42:46AM -0800, Luigi Rizzo wrote: > [moving to arch] > > sorry if it has been debated already, but looking in the > network code it seems that checks for architectures that > need strong alignment are done through a sequence of > > #if defined(__ia64__) || defined(__blah__) || ... > > one such sequence is in net/if_loop::if_simloop(), and was > related to a problem we are having with some recent > commits to net/if_ethersubr.c > > While the easy fix (for this one) is to add > || defined(__arm__) > to the sequence, we were wondering if there is some identifier > that we can use to the purpose. > > Bernd Walter was suggesting this: > > > I would have said ALIGNBYTES != 1, but this also matches with i386. > > Guess it's time to introduce somehing like ALIGN_STRONG, or whatever > > colour fits best. > > ideas ? Architectures without strong alignment define __NO_STRICT_ALIGNMENT in . Stefan