From owner-p4-projects@FreeBSD.ORG  Tue Sep 16 20:05:09 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id D71A5106567E; Tue, 16 Sep 2008 20:05:08 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 913781065676
	for <perforce@freebsd.org>; Tue, 16 Sep 2008 20:05:08 +0000 (UTC)
	(envelope-from raj@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 682938FC16
	for <perforce@freebsd.org>; Tue, 16 Sep 2008 20:05:08 +0000 (UTC)
	(envelope-from raj@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id m8GK584C041888
	for <perforce@freebsd.org>; Tue, 16 Sep 2008 20:05:08 GMT
	(envelope-from raj@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.3/8.14.3/Submit) id m8GK58MM041882
	for perforce@freebsd.org; Tue, 16 Sep 2008 20:05:08 GMT
	(envelope-from raj@freebsd.org)
Date: Tue, 16 Sep 2008 20:05:08 GMT
Message-Id: <200809162005.m8GK58MM041882@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	raj@freebsd.org using -f
From: Rafal Jaworowski <raj@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 149897 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Sep 2008 20:05:09 -0000

http://perforce.freebsd.org/chv.cgi?CH=149897

Change 149897 by raj@raj_mimi on 2008/09/16 20:04:52

	mge: Drop RX lock before before calling if_input() since we can recurse
	on mge_start() and end up with a lock order reversal.

Affected files ...

.. //depot/projects/arm/src/sys/dev/mge/if_mge.c#5 edit

Differences ...

==== //depot/projects/arm/src/sys/dev/mge/if_mge.c#5 (text+ko) ====

@@ -993,7 +993,9 @@
 			mge_offload_process_frame(ifp, mb, status,
 			    bufsize);
 
+			MGE_RECEIVE_UNLOCK(sc);
 			(*ifp->if_input)(ifp, mb);
+			MGE_RECEIVE_LOCK(sc);
 		}
 
 		dw->mge_desc->byte_count = 0;