From owner-freebsd-current@FreeBSD.ORG Wed Apr 21 02:09:32 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7D59616A4CE for ; Wed, 21 Apr 2004 02:09:32 -0700 (PDT) Received: from darkness.comp.waw.pl (darkness.comp.waw.pl [195.117.238.236]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2039143D48 for ; Wed, 21 Apr 2004 02:09:32 -0700 (PDT) (envelope-from pjd@darkness.comp.waw.pl) Received: by darkness.comp.waw.pl (Postfix, from userid 1009) id 14518ACBD2; Wed, 21 Apr 2004 11:09:31 +0200 (CEST) Date: Wed, 21 Apr 2004 11:09:31 +0200 From: Pawel Jakub Dawidek To: Alex Lyashkov Message-ID: <20040421090931.GO24376@darkness.comp.waw.pl> References: <1082477860.8258.105.camel@berloga.shadowland> <20040421083009.GN24376@darkness.comp.waw.pl> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="jcwRHPSxFqmwpRFb" Content-Disposition: inline In-Reply-To: <20040421083009.GN24376@darkness.comp.waw.pl> User-Agent: Mutt/1.4.2i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 5.2.1-RC2 i386 cc: freebsd-current@freebsd.org Subject: Re: kernel panic at quotactl with 5.2-current X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Apr 2004 09:09:32 -0000 --jcwRHPSxFqmwpRFb Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 21, 2004 at 10:30:09AM +0200, Pawel Jakub Dawidek wrote: +> +> This patch fixed this problem. +>=20 +> Your fix is probably only a workaround. +> The problem is more complex, because vn_start_write() is able to return 0 +> and mp =3D=3D NULL when operation is not supported by file system. +> I'm not yet sure if we just can't fix vn_start_write() to return +> EOPNOTSUPP when needed, but there is a special case for this: +>=20 +> if (error !=3D EOPNOTSUPP) +> return (error); +> return (0); +>=20 +> and I must figure out why. There are many vn_start_write() consumers, +> so this can take a while. +> Anyway, thank you for your report. Ok, quotactl() is probably the only place which use vn_start_write() not properly. Could you test this patch: http://people.freebsd.org/~pjd/patches/vfs_syscalls.c.2.patch The only different between yours patch and mine is that I'm returning EOPNOTSUPP instead of 0 if file system doesn't support quotas. --=20 Pawel Jakub Dawidek http://www.FreeBSD.org pjd@FreeBSD.org http://garage.freebsd.pl FreeBSD committer Am I Evil? Yes, I Am! --jcwRHPSxFqmwpRFb Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAhjpLForvXbEpPzQRAhaBAJ0Tntlua43WY834R3UekUGa785IsQCfdgzc rXLPTYeboA1JtehnViNHMNc= =oFM+ -----END PGP SIGNATURE----- --jcwRHPSxFqmwpRFb--