From owner-cvs-all@FreeBSD.ORG Tue Apr 29 11:09:10 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 86EB937B407 for ; Tue, 29 Apr 2003 11:09:10 -0700 (PDT) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id DF63E43FB1 for ; Tue, 29 Apr 2003 11:09:08 -0700 (PDT) (envelope-from nate@rootlabs.com) Received: (qmail 75743 invoked by uid 1000); 29 Apr 2003 18:09:09 -0000 Date: Tue, 29 Apr 2003 11:09:09 -0700 (PDT) From: Nate Lawson To: Warner Losh In-Reply-To: <20030429054515.D74EF37B490@hub.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/fxp if_fxp.c if_fxpvar.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Apr 2003 18:09:10 -0000 On Mon, 28 Apr 2003, Warner Losh wrote: > Modified files: > sys/dev/fxp if_fxp.c if_fxpvar.h > Log: > Fix 5 bugs: > 1) always call fxp_stop in fxp_detach. Since we don't read from > the card, there's no need to carefully look at things with > bus_child_present. However, we do write to the card registers (i.e. to disable interrupt generation). Since you were the one who suggested I should add these calls, can you give more information about when bus_child_present should be used (and update the man page if anything changed)? > 2) Call FXP_UNLOCK() before calling bus_teardown_intr to avoid > a possible deadlock reported by jhb. This adds a race since fxp_intr could occur after the unlock but before the bus_teardown_intr call. The reason why I tore down the intr while holding the lock is so fxp_intr would be prevented from accessing the device until it has been disabled. Then the normal checks in fxp_intr (IFF_OACTIVE or whatever) would show the card is gone and return without accessing it. I guess this is ok since ether_ifdetach is still called with the lock held (since it is what clears IFF_OACTIVE) but I'm interested in your thoughts. > 3) add gone to the softc. Set it to true in detach. > 4) Return immediately if gone is true in fxp_ioctl > 5) Return immediately if gone is true in fxp_intr Not sure this approach is necessary. -Nate