From owner-svn-src-all@FreeBSD.ORG Wed Nov 5 03:45:40 2008 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B10641065672 for ; Wed, 5 Nov 2008 03:45:40 +0000 (UTC) (envelope-from unixmania@gmail.com) Received: from ey-out-2122.google.com (ey-out-2122.google.com [74.125.78.26]) by mx1.freebsd.org (Postfix) with ESMTP id 424A08FC08 for ; Wed, 5 Nov 2008 03:45:39 +0000 (UTC) (envelope-from unixmania@gmail.com) Received: by ey-out-2122.google.com with SMTP id 6so1180433eyi.7 for ; Tue, 04 Nov 2008 19:45:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=3JGfeUVbfD3IjnOaLPdnAtjoo+tJ+5tg5oqP0XBfJuo=; b=yGc8W7RVz5ozQpuCP5uJlFKqp6MFkj3zl2u90RRIze7bJAOmLwwC6SFTE4MI2827X8 pxZwemwe8JH6s1K8+Fx/k8jmNF3ladKDXoab3TiIu/zCQL79BRt/JOK2dUwIYy8tVMp3 mZkEmd+K2NyZwdfZE5Do+rA0sSnyfD4tv6ss8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=hLSqNA+6ALa/Qts4PskWfVu+CrcixXZ/n18MBEYQukP0CHnVa2699/vBGtEzcagYDz gIoxvza+lyCQNUKVreKitDlGSMF24i/3RBEK4lftXTxWYuLyFef/HJdsJjrT6RbgQtvO FL3rkUeuO2hOYIRWUhfKCFXapvav2qUPWvjeU= Received: by 10.210.37.16 with SMTP id k16mr437002ebk.75.1225856738965; Tue, 04 Nov 2008 19:45:38 -0800 (PST) Received: by 10.210.54.9 with HTTP; Tue, 4 Nov 2008 19:45:38 -0800 (PST) Message-ID: Date: Wed, 5 Nov 2008 01:45:38 -0200 From: "Carlos A. M. dos Santos" To: "Joerg Sonnenberger" In-Reply-To: <20081103225453.GA1509@britannica.bec.de> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200811032209.mA3M9RhK077380@svn.freebsd.org> <490F800E.9080201@gmx.de> <20081103225453.GA1509@britannica.bec.de> Cc: svn-src-all@freebsd.org Subject: Re: svn commit: r184605 - head/sys/dev/usb X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Nov 2008 03:45:40 -0000 On Mon, Nov 3, 2008 at 8:54 PM, Joerg Sonnenberger wrote: > On Mon, Nov 03, 2008 at 11:49:50PM +0100, Christoph Mallon wrote: >> You may want to make cmd[] static and/or const, so the compiler really >> just puts the bytes in the data section instead of generating code, >> which pretty much is the same as the assignments you just removed. > > I didn't make it const originally as I am not sure if the USB stack will > never modify the buffer. You may want to have a const array and memcpy it to cmd before calling usbd_transfer(). This will be smaller, though not much faster. -- cd /usr/ports/sysutils/life make clean