From owner-freebsd-current@FreeBSD.ORG Wed Apr 13 16:27:15 2005 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D34D916A4CE for ; Wed, 13 Apr 2005 16:27:15 +0000 (GMT) Received: from sp.dominia.org (efnet-math.org [69.60.109.125]) by mx1.FreeBSD.org (Postfix) with ESMTP id 341FA43D6B for ; Wed, 13 Apr 2005 16:27:15 +0000 (GMT) (envelope-from ssouhlal@FreeBSD.org) Received: from [198.82.174.233] (hc652aee9.dhcp.vt.edu [198.82.174.233]) (authenticated bits=0) by sp.dominia.org (8.13.1/8.13.1) with ESMTP id j3DGRCu9009246 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NO); Wed, 13 Apr 2005 12:27:13 -0400 In-Reply-To: <20050412232841.230467c2@kan.dnsalias.net> References: <0842a01b5aa0cfcd84763fff4a30113e@FreeBSD.org> <20050412232841.230467c2@kan.dnsalias.net> Mime-Version: 1.0 (Apple Message framework v619.2) Content-Type: text/plain; charset=US-ASCII; format=flowed Message-Id: Content-Transfer-Encoding: 7bit From: Suleiman Souhlal Date: Wed, 13 Apr 2005 12:27:11 -0400 To: Alexander Kabaev X-Mailer: Apple Mail (2.619.2) cc: current@FreeBSD.org Subject: Re: [PATCH] Allow watching of vnodes that reside on non-UFS filesystems with kqueue X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Apr 2005 16:27:15 -0000 Hi, On Apr 12, 2005, at 11:28 PM, Alexander Kabaev wrote: > I for one am not thrilled by all the hooks being made unconditional and > being inserted right into the middle of critical path for the benefit > of > rarely used feature. I don't think there is actually any cost. The hooks are only used when they are actually 'declared' in vnode_if.src, and they could very well get inlined by the compiler. -- Suleiman Souhlal | ssouhlal@vt.edu The FreeBSD Project | ssouhlal@FreeBSD.org