From owner-svn-src-all@freebsd.org Tue Nov 1 15:23:28 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 376ECC2910B for ; Tue, 1 Nov 2016 15:23:28 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: from mail-yw0-x22d.google.com (mail-yw0-x22d.google.com [IPv6:2607:f8b0:4002:c05::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EA53917B7; Tue, 1 Nov 2016 15:23:27 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: by mail-yw0-x22d.google.com with SMTP id r204so72409510ywb.0; Tue, 01 Nov 2016 08:23:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=FH6+iWfZaoo5CK6nkR6FAPOy/TfjUkv6MwRIn0Y6+80=; b=DOpLKNGWuyW9ppgQTXWHS2DLe5bs/146trpXft7e8xsaGjfYX/iCIzOQ8FVu6QhLKP RzpNIw7M/1ypdCyITfwyRXLda8qHxjIJxLDizNZlLEE/ib+3To+UKmWK2IE8fOJGo3NJ 5jdU/DeI0JjmAmmnfp6A+RAG3xR2Z9CAv2cwfvtgex8aIO2Acq3AM2+IaqLLhB9tQFTa +msbUlsUyDSbVBNBFaQJHBMnSj85EW37ZiJ+dmSp1C7yd6WWgQqE1pqUONXZYhlraPDB pwpJpY7yZv0aPGPx2ssjb6V21NWdyUw1z2a/gbLH1CNWnNEz4FfZzPI6dlDqiZiBkJy5 U/VQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=FH6+iWfZaoo5CK6nkR6FAPOy/TfjUkv6MwRIn0Y6+80=; b=DLaKtDhMqFXCybSiNhQUAL7phweY1PmlwwRVZpuaSK0Lp+dKMvNDlDKrfIpyveo/rY rcGaEmA1Ur+1qk6oqt5KRkNpFUHhGlDQfLh5twxBGsogIPMJiCBhOFIofDc+7biBmE9Z onwnaaEHyTJNR+6cru3uJPFgyKz7+scD6iSa/QGmZSCAxpRWKJUHlPqwh23ZSCYEdP/A Zlaq1zeYFDJiJ/FhsyXxgawX1gMe7Q84DfOcBrfnXxZjHs9SUJRIH6+7Kw49G/UwQjMA bxpJPxXqp6cpNNlNCswyYwmoY8vbb4oBQ5YNfCzWXjS3pYjML/k7FL0zn6mPIREThwh9 382Q== X-Gm-Message-State: ABUngvf4+ErfPVBLReGQ6QnXWTbZDrXDgJikX8Khu/qEJYfLXcBYIwm77f+qaRE6YyAF+sopnJyx30bhuAQ28A== X-Received: by 10.36.106.76 with SMTP id l73mr1537610itc.115.1478013806928; Tue, 01 Nov 2016 08:23:26 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.162.133 with HTTP; Tue, 1 Nov 2016 08:23:26 -0700 (PDT) In-Reply-To: <5818B132.5060400@omnilan.de> References: <201608182259.u7IMxAbm002067@repo.freebsd.org> <5818B132.5060400@omnilan.de> From: Ryan Stone Date: Tue, 1 Nov 2016 11:23:26 -0400 Message-ID: Subject: Re: svn commit: r304437 - head/sys/netinet To: Harry Schmalzbauer Cc: Ryan Stone , "svn-src-all@freebsd.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Nov 2016 15:23:28 -0000 There are some performance implications of this change that are unresolved in the UDP receive path. I haven't had a chance to go back and try to address that, so I can't MFC until then. On Tue, Nov 1, 2016 at 11:13 AM, Harry Schmalzbauer wrote: > Bez=C3=BCglich Ryan Stone's Nachricht vom 19.08.2016 00:59 (localtime): > > Author: rstone > > Date: Thu Aug 18 22:59:10 2016 > > New Revision: 304437 > > URL: https://svnweb.freebsd.org/changeset/base/304437 > > > > Log: > > Fix unlocked access to ifnet address list > > > > in_broadcast() was iterating over the ifnet address list without > > first taking an IF_ADDR_RLOCK. This could cause a panic if a > > concurrent operation modified the list. > > > > Reviewed by: bz > > MFC after: 2 months > > Sponsored by: EMC / Isilon Storage Division > > Differential Revision: https://reviews.freebsd.org/D7227 > > Is this intentionally unMFCd? > > Thanks, > > -harry > >