From owner-cvs-all  Wed Apr 11  8:50:27 2001
Delivered-To: cvs-all@freebsd.org
Received: from ipcard.iptcom.net (ipcard.iptcom.net [212.9.224.5])
	by hub.freebsd.org (Postfix) with ESMTP
	id 51DDD37B422; Wed, 11 Apr 2001 08:50:08 -0700 (PDT)
	(envelope-from sobomax@FreeBSD.org)
Received: from vic.sabbo.net (dialup4-7.iptelecom.net.ua [212.9.226.199])
	by ipcard.iptcom.net (8.9.3/8.9.3) with ESMTP id SAA96837;
	Wed, 11 Apr 2001 18:50:01 +0300 (EEST)
	(envelope-from sobomax@FreeBSD.org)
Received: from FreeBSD.org (big_brother.vega.com [192.168.1.1])
	by vic.sabbo.net (8.11.3/8.11.2) with ESMTP id f3BFnTt35873;
	Wed, 11 Apr 2001 18:49:29 +0300 (EEST)
	(envelope-from sobomax@FreeBSD.org)
Message-ID: <3AD47CF5.37C2D973@FreeBSD.org>
Date: Wed, 11 Apr 2001 18:49:10 +0300
From: Maxim Sobolev <sobomax@FreeBSD.org>
Organization: Vega International Capital
X-Mailer: Mozilla 4.77 [en] (WinNT; U)
X-Accept-Language: uk,ru,en
MIME-Version: 1.0
To: Mikhail Teterin <mi@aldan.algebra.com>
Cc: mi@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: ports/graphics/lcms Makefile distinfo pkg-descrpkg-plist
References: <200104111432.f3BEWoA09878@aldan.algebra.com>
Content-Type: text/plain; charset=koi8-r
Content-Transfer-Encoding: 7bit
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

Mikhail Teterin wrote:

> On 11 Apr, Maxim Sobolev wrote:
> > Mikhail Teterin wrote:
> >
> >> mi          2001/04/10 16:14:06 PDT
> >>
> >>   Modified files:
> >>     graphics/lcms        Makefile distinfo pkg-descr pkg-plist
> >>   Log:
> >>   Upgrade to 1.07. Use the official PORTDOCS instead of the pre-PORTDOCS
> >>   homegrown DOCS variable. Do not install the test-executable, but run it
> >>   after build.
> >
> > What is the point of doing so? Why do you think it is useful to run this on
> > the user's machine?
>
> It tests if the compiled library passes its own tests after it is built.
>
> I wish, all ports had this feature. With a variety of optimization
> options and tricks the software authors do, I believe, this is a good
> thing. FYI, information bzip2 does this too. And hdf. TCL and TK should,
> but don't (TCL's tests are not very accurate and trigger false negatives
> sometimes)...

I can't agree with you. I certainly don't want any superfluous tests run on my
machine, just consuming my time. Perhaps you are overdesigning things. If you
really think that it is a good thing, please provide a method to disable/enable
those tests, or even better - separate rule and a post-install note:
test:
    blabla

post-install:
    ${ECHO_MSG} "If you want to ensure that the foo library you just built does
work please type \"make test\"."

In general please don't make any unusual assumptions about user's preferences.
BTW, the same applies for the automatic -j2 in your several ports - there is no
way to disable it, while in low memory conditions it may pessimise performance
due to additional swaping.

-Maxim


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message