From nobody Wed Jun 11 17:05:47 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bHX9h4ZQBz5yB5J for ; Wed, 11 Jun 2025 17:06:00 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bHX9g6qHbz3f77 for ; Wed, 11 Jun 2025 17:05:59 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-3a507e88b0aso128219f8f.1 for ; Wed, 11 Jun 2025 10:05:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749661558; x=1750266358; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5acwD2pAooMtXbPq/ppU/UiUWcXHeAoC73xbEYn/6BY=; b=d2v9Qxb1RGXq28mpJDQI5hLcPiOF+2br1Z6wdsmSL1z6QeRHCOvWAZpOGk/7xgjHLg 0MOC+qqdWKyZj7zLM+CYZdmO45gp+vecp1gRfRNSYQss2OCkLXaBlxI+vqVKnLLwiNIN Wpgp8Cu0SC6OaV5sqosJZgLzf9UTGfSHpEmcZ+dYQInHtKQ8RO77ljei84AGzHGEPtMP tTuJ8XvhXj6kED23jVEIo4hpuYZjRKSj47CRM20m+aBpZOnp4Cb+HR/3+4Y4Brhui3kp bh7uEPdcJGE1gkN3NcjI7h+qmvMNAr4aqCQAZdM7IphjvYw4pgAOXSrciVMhSYRZo54t uUog== X-Forwarded-Encrypted: i=1; AJvYcCVeueJAG/E84dQM0CrJS8p/zjvwwb9RBnJraVtKDF6bc3Lnz2z7dHVhXPQeGrCDC5QEJcdqI4Do4p3SVqQw1PW2P1Iopg==@freebsd.org X-Gm-Message-State: AOJu0Yz10BwXZ5EBzU4H+8yyG0xwvhEoJoFDTgVGlw6vOP4EM7iIJRn1 HDmN22kqfQma/0/IXTGNYSFLZhiV2ALALbT6Qnm0BYJzIGb6vyTUlKrQn7XmWUtjvfFHSeH3LE9 3Eras X-Gm-Gg: ASbGnctAPbo6LvQKyuUk63tAzG3yZ8VxBFrdjv75OGexVD4OPLsloDrHeZteNBnRKxy TEDqHN7ZGXuG1r3iFI0jF3JVhkglVb+icOzk15efEYuO2TGXVaWgKluheRgGSLMigWk1PaKyEv6 VR+cUfvF0/peVx1L4lIhVWWI55MalwkENpufX2q18CGAZe1RzkzCBP0CNzAu1A9ocOhFmKuMU9w CNpUZeJw7uSNCIwzgMb6c6D0vbbvar6Wpiitmv+O2wwctTnbwjiKYsSTKYiC/DhyMaywQ4QW9qC i82jkp5GCcDbtXfEZmJq4FMCFpdLyQSgDf9XUzIJVUWdLxvjUYYgOAG2oSU08LueZ5justrmjIP N X-Google-Smtp-Source: AGHT+IGxtrFbUrYYjmUcYSX3FJBNE7TdYTOsE6d9v45+o6MP3MHbYUgClBItCMlI1Ie1/8nz6VnMLw== X-Received: by 2002:a05:6000:3104:b0:3a4:e75f:53f5 with SMTP id ffacd0b85a97d-3a5607c965emr132851f8f.35.1749661558005; Wed, 11 Jun 2025 10:05:58 -0700 (PDT) Received: from smtpclient.apple ([131.111.5.201]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a53244f516sm15814981f8f.74.2025.06.11.10.05.57 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Jun 2025 10:05:57 -0700 (PDT) Content-Type: text/plain; charset=us-ascii List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.600.51.1.1\)) Subject: Re: git: ab3d713e93dc - main - sys/_types.h: use builtins to for __max_align_t From: Jessica Clarke In-Reply-To: <202506111700.55BH0Ka6042574@gitrepo.freebsd.org> Date: Wed, 11 Jun 2025 18:05:47 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <37D99680-366D-4D11-BC19-B6D676FA1E22@freebsd.org> References: <202506111700.55BH0Ka6042574@gitrepo.freebsd.org> To: Brooks Davis X-Mailer: Apple Mail (2.3826.600.51.1.1) X-Rspamd-Queue-Id: 4bHX9g6qHbz3f77 X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] On 11 Jun 2025, at 18:00, Brooks Davis wrote: >=20 > The branch main has been updated by brooks: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3Dab3d713e93dc1d322398657125071101= c08e2ce5 >=20 > commit ab3d713e93dc1d322398657125071101c08e2ce5 > Author: Brooks Davis > AuthorDate: 2025-06-11 16:39:01 +0000 > Commit: Brooks Davis > CommitDate: 2025-06-11 16:39:01 +0000 >=20 > sys/_types.h: use builtins to for __max_align_t >=20 > Use __attribute__((__aligned__(x))) and __alignof__(x) in places of = local > macros that ultimately wrap these. We don't support compilers that = don't > define these so there's little loss of generality. >=20 > This mirrors Clang's stddef.h. >=20 > Reviewed by: imp > Exp-run by: antoine (PR 286274) > Pull Request: https://github.com/freebsd/freebsd-src/pull/1595 > --- > sys/sys/_types.h | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git a/sys/sys/_types.h b/sys/sys/_types.h > index c84b84edd2b8..f6d1f26551e0 100644 > --- a/sys/sys/_types.h > +++ b/sys/sys/_types.h > @@ -181,9 +181,11 @@ typedef __uint_least32_t __char32_t; > #endif >=20 > typedef struct { > - long long __max_align1 __aligned(_Alignof(long long)); > + long long __max_align1 > + __attribute__((__aligned__(__alignof__(long long)))); > #ifndef _STANDALONE > - long double __max_align2 __aligned(_Alignof(long double)); > + long double __max_align2 > + __attribute__((__aligned__(__alignof__(long long)))); > #endif > } __max_align_t; >=20 _Alignof is the standard C spelling of it. We should be adopting the standard names for things more, polyfilling with GNU macros when not available, not increasing our use of old GNU C equivalents that predate their additions to the standard. This should really be _Alignas(_Alignof(...)). Jess