From owner-cvs-src@FreeBSD.ORG  Fri Mar 26 10:34:07 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id E756516A4CE; Fri, 26 Mar 2004 10:34:06 -0800 (PST)
Received: from fledge.watson.org (fledge.watson.org [204.156.12.50])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 81CED43D45; Fri, 26 Mar 2004 10:34:06 -0800 (PST)
	(envelope-from robert@fledge.watson.org)
Received: from fledge.watson.org (localhost [127.0.0.1])
	by fledge.watson.org (8.12.10/8.12.10) with ESMTP id i2QIVqxC083207;
	Fri, 26 Mar 2004 13:31:52 -0500 (EST)
	(envelope-from robert@fledge.watson.org)
Received: from localhost (robert@localhost)i2QIVqBI083204;
	Fri, 26 Mar 2004 13:31:52 -0500 (EST)
	(envelope-from robert@fledge.watson.org)
Date: Fri, 26 Mar 2004 13:31:51 -0500 (EST)
From: Robert Watson <rwatson@FreeBSD.org>
X-Sender: robert@fledge.watson.org
To: Garance A Drosehn <gad@FreeBSD.org>
In-Reply-To: <p06020492bc8a2491cfed@[128.113.24.47]>
Message-ID: <Pine.NEB.3.96L.1040326133113.79234F-100000@fledge.watson.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/usr.bin/pkill pkill.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 26 Mar 2004 18:34:07 -0000


On Fri, 26 Mar 2004, Garance A Drosehn wrote:

> At 1:11 PM -0500 3/26/04, Robert Watson wrote:
> >On Fri, 26 Mar 2004, Garance A Drosehn wrote:
> >
> >>    Modified files:
> >>      usr.bin/pkill        pkill.c
> >>    Log:
> >  >   Switch to checking P_KTHREAD instead of P_SYSTEM when
> >  >   deciding what "system processes" to always ignore.
> >
> >Either our definition or my understanding of P_KTHREAD vs
> >P_SYSTEM is weak.  P_SYSTEM seems to include init, and
> >P_KTHREAD seems to mean things that really are kprocs, but
> >there was some recent discussion of the details of this on
> >arch@ with regard to whether signals should be delivered to
> >things that are arguably kernel threads or processes.
> 
> It would not surprise me if P_KTHREAD is not the most correct check for
> me to make here, but in my debugging it sure seems like using P_SYSTEM
> results in some processes getting skipped that I do not expect to be
> skipped. 

I'm actually not complaining about your change (if anything, it seems
right to me), but rather pointing out that our implementation may be
confused and that has resulted in what you bumped into.

Robert N M Watson             FreeBSD Core Team, TrustedBSD Projects
robert@fledge.watson.org      Senior Research Scientist, McAfee Research