Date: Wed, 27 Feb 2013 00:27:47 GMT From: Kevin Zheng <kevinz5000@gmail.com> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/176459: [patch] Update COMMENT and pkg-descr for devel/astyle Message-ID: <201302270027.r1R0Rl17013180@red.freebsd.org> Resent-Message-ID: <201302270030.r1R0U0Ss017431@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 176459
>Category: ports
>Synopsis: [patch] Update COMMENT and pkg-descr for devel/astyle
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Wed Feb 27 00:30:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator: Kevin Zheng
>Release: 9.1-RELEASE
>Organization:
>Environment:
FreeBSD sigma.local 9.1-RELEASE FreeBSD 9.1-RELEASE #0 r243826: Tue Dec 4 06:55:39 UTC 2012 root@obrian.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC i386
>Description:
Update COMMENT and pkg-descr for devel/astyle. While here,
- Trim Makefile header.
- Eradicate evil NOPORTDOCS in favor of OptionsNG.
Also, I was wondering whether it was possible to make GCC just a BUILD_DEPENDS. Right now astyle pulls in a bunch of GCC-related dependencies even when I install it from a binary package.
Does Clang fix the UTF-8 compile issue as well?
>How-To-Repeat:
>Fix:
Apply the attached patch (generated by `svn diff`).
Patch attached with submission follows:
Index: Makefile
===================================================================
--- Makefile (revision 313014)
+++ Makefile (working copy)
@@ -1,9 +1,5 @@
-# New ports collection makefile for: astyle
-# Date created: 31 Jan 1999
-# Whom: Don Croyle <croyle@gelemna.org>
-#
+# Created by: Don Croyle <croyle@gelemna.org>
# $FreeBSD$
-#
PORTNAME= astyle
PORTVERSION= 2.02.1
@@ -12,7 +8,7 @@
DISTNAME= ${PORTNAME}_${PORTVERSION}_linux
MAINTAINER= lme@FreeBSD.org
-COMMENT= A reindenter and reformatter of C, C++, C\#, and Java source code
+COMMENT= Source code indenter and formatter for C, C++, C\#, and Java
ALL_TARGET= astyle
CFLAGS+= -W -Wall -fno-rtti -fno-exceptions
@@ -26,14 +22,16 @@
pre-patch:
@${REINPLACE_CMD} -e 's,^CFLAGS,#CFLAGS,; s,g++,${CXX},;' ${WRKSRC}/Makefile
+.include <bsd.port.options.mk>
+
PLIST_FILES= bin/astyle
-.if !defined(NOPORTDOCS)
+.if ${PORT_OPTIONS:MDOCS}
PORTDOCS= *
.endif
do-install:
${INSTALL_PROGRAM} ${WRKSRC}/bin/astyle ${PREFIX}/bin
-.if !defined(NOPORTDOCS)
+.if ${PORT_OPTIONS:MDOCS}
${MKDIR} ${DOCSDIR}
${INSTALL_DATA} ${WRKDIR}/astyle/doc/*.html ${DOCSDIR}
.endif
Index: pkg-descr
===================================================================
--- pkg-descr (revision 313014)
+++ pkg-descr (working copy)
@@ -1,3 +1,5 @@
-Artistic Style is a variant on indent that can handle C, C++ and Java source.
+Artistic Style is a source code indenter, formatter, and beautifier for the C,
+C++, C# and Java programming languages. It automatically re-indents and
+re-formats source files and can be used from a command line.
WWW: http://astyle.sourceforge.net/
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201302270027.r1R0Rl17013180>