From owner-freebsd-stable@FreeBSD.ORG Sat Apr 19 09:52:23 2003 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 08B4837B401; Sat, 19 Apr 2003 09:52:22 -0700 (PDT) Received: from mx1.evo6.net (mx1.evo6.net [80.76.194.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id B286443FBF; Sat, 19 Apr 2003 09:52:21 -0700 (PDT) (envelope-from andy@evo6.org) Received: from vx (vx.noc.evo6.net [10.0.0.10]) by mx1.evo6.net (8.12.9/8.12.9) with SMTP id h3JGqJhH097683; Sat, 19 Apr 2003 17:52:19 +0100 (BST) (envelope-from andy@evo6.org) Message-ID: <000901c30694$091bd010$0a00000a@vx> From: "Andy Gilligan" To: "Gregory Neil Shapiro" References: <000801c3067d$b6379340$0a00000a@vx> <20030419161506.GE5607@horsey.gshapiro.net> Date: Sat, 19 Apr 2003 17:52:16 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2800.1106 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1106 X-Spam-Status: No, hits=-9.8 required=5.0 tests=QUOTED_EMAIL_TEXT,REFERENCES version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) cc: stable@freebsd.org Subject: Re: MFC for sysctl descriptions X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Apr 2003 16:52:23 -0000 Yes, it should... I was wondering about this myself. Although, it is also just called 'descr' in -CURRENT, and I was initially unsure if this would have any impact on the rest of the kernel. After delving a little deeper I see no reason for it to be kept as 'descr', so I have modified the patch accordingly. I have just recompiled my own kernel, with the 'oid_descr' field changes and everything seems to be ok. Best regards, - Andy ----- Original Message ----- From: "Gregory Neil Shapiro" To: "Andy Gilligan" Sent: Saturday, April 19, 2003 5:15 PM Subject: Re: MFC for sysctl descriptions > One comment on the patch: > > --- sys/sys/sysctl.h 9 Sep 2002 19:27:54 -0000 1.81.2.9 > +++ sys/sys/sysctl.h 19 Apr 2003 13:24:38 -0000 > @@ -133,6 +133,7 @@ > int (*oid_handler)(SYSCTL_HANDLER_ARGS); > const char *oid_fmt; > int oid_refcnt; > + const char *descr; > }; > > Shouldn't that be oid_descr to match the style of the rest of the > structure elements? >