From owner-svn-src-head@FreeBSD.ORG  Wed Sep 24 14:12:06 2014
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 11A6C780;
 Wed, 24 Sep 2014 14:12:06 +0000 (UTC)
Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id DBEC0196;
 Wed, 24 Sep 2014 14:12:05 +0000 (UTC)
Received: from ralph.baldwin.cx (pool-173-70-85-31.nwrknj.fios.verizon.net
 [173.70.85.31])
 by bigwig.baldwin.cx (Postfix) with ESMTPSA id C8569B97D;
 Wed, 24 Sep 2014 10:12:04 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: Konstantin Belousov <kostikbel@gmail.com>
Subject: Re: svn commit: r272032 - head/sys/conf
Date: Wed, 24 Sep 2014 09:58:07 -0400
Message-ID: <8280436.uSRo73F0Mt@ralph.baldwin.cx>
User-Agent: KMail/4.10.5 (FreeBSD/10.0-STABLE; KDE/4.10.5; amd64; ; )
In-Reply-To: <20140923184434.GG8870@kib.kiev.ua>
References: <201409231704.s8NH4Lcv098184@svn.freebsd.org>
 <5421BC8E.6000709@FreeBSD.org> <20140923184434.GG8870@kib.kiev.ua>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
 (bigwig.baldwin.cx); Wed, 24 Sep 2014 10:12:04 -0400 (EDT)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org, Bryan Drewery <bdrewery@freebsd.org>
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Sep 2014 14:12:06 -0000

On Tuesday, September 23, 2014 09:44:34 PM Konstantin Belousov wrote:
> On Tue, Sep 23, 2014 at 01:31:42PM -0500, Bryan Drewery wrote:
> > On 9/23/2014 1:20 PM, Konstantin Belousov wrote:
> > > On Tue, Sep 23, 2014 at 05:04:21PM +0000, Bryan Drewery wrote:
> > >> Author: bdrewery
> > >> Date: Tue Sep 23 17:04:21 2014
> > >> New Revision: 272032
> > >> URL: http://svnweb.freebsd.org/changeset/base/272032
> > >> 
> > >> Log:
> > >>   DEBUG_LOCKS no longer modifies 'struct vnode', nor does fstat(1) use
> > >>   it.
> > >>   fstat(1) now uses libprocstat(9).  There is no userland impact to
> > >>   using this.> > 
> > > DEBUG_VFS_LOCKS does modify KBI of VFS, by adding struct stack to
> > > lockmgr, and lockmgr is embedded into each struct vnode.
> > > 
> > > VFS modules, in particular, filesystems, compiled for mismatched
> > > kernel WRT DEBUG_VFS_LOCKS, would cause strange breakage.
> > 
> > Well, perhaps the comment needs to be updated to state that
> > DEBUG_VFS_LOCKS modifies VFS KBI so any VFS modules will need to
> > recompiled.
> > 
> > I did see the stack was moved to lockmgr, but given the use of
> > libprocstat, and lockmgr being a kernel struct, I don't think it's worth
> > mentioning userland here.
> > 
> > Sound good?
> 
> I agree, I do not think that userland is affected.

It is for at least lsof (which does not use libprocstat and cannot easily be 
adopted to use it exclusively as it pulls a lot more data out than libprocstat 
exports such as the info about file locks, etc.)

-- 
John Baldwin