From owner-cvs-all@FreeBSD.ORG  Wed Jun 13 06:58:59 2012
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx2.freebsd.org (mx2.freebsd.org [69.147.83.53])
	by hub.freebsd.org (Postfix) with ESMTP id 5540A106564A;
	Wed, 13 Jun 2012 06:58:59 +0000 (UTC)
	(envelope-from dougb@FreeBSD.org)
Received: from opti.dougb.net (hub.freebsd.org [IPv6:2001:4f8:fff6::36])
	by mx2.freebsd.org (Postfix) with ESMTP id C328B1554DE;
	Wed, 13 Jun 2012 06:58:52 +0000 (UTC)
Message-ID: <4FD83A2C.3030500@FreeBSD.org>
Date: Tue, 12 Jun 2012 23:58:52 -0700
From: Doug Barton <dougb@FreeBSD.org>
Organization: http://SupersetSolutions.com/
User-Agent: Mozilla/5.0 (X11; FreeBSD i386;
	rv:13.0) Gecko/20120611 Thunderbird/13.0
MIME-Version: 1.0
To: "Sergey A. Osokin" <osa@FreeBSD.org>
References: <201206130446.q5D4kEb3031676@repoman.freebsd.org>
	<4FD834FB.7050705@FreeBSD.org> <20120613064656.GM20963@FreeBSD.org>
In-Reply-To: <20120613064656.GM20963@FreeBSD.org>
X-Enigmail-Version: 1.4.2
OpenPGP: id=1A1ABC84
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/www/nginx Makefile ports/www/nginx/files
 nginx.sh.in
 ports/www/nginx-devel Makefile ports/www/nginx-devel/files nginx.sh.in
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the entire tree
	<cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Jun 2012 06:58:59 -0000

On 06/12/2012 23:46, Sergey A. Osokin wrote:
> Hi Doug,
> 
> On Tue, Jun 12, 2012 at 11:36:43PM -0700, Doug Barton wrote:
>> Since it's only called in one place, there's no need to put the
>> directory code in a function. Also, instead of doing it in 3 steps you
>> can unconditionally use install as follows:
>>
>> install -d -o %%WWWOWN%% -g %%WWWGRP%% -m 755 ${_tmpprefix}
> 
> I do this at Makefile:
> ...
>         ${MKDIR} ${ETCDIR} ${NGINX_TMPDIR}
>         ${CHOWN} ${WWWOWN}:${WWWGRP} ${NGINX_TMPDIR}

You should not do that in the Makefile since it's worthless for
packages. Also, the rc.d script should always do whatever is necessary
to make the service work ... both for general purposes and for packages.

> Also, I do my changes in nginx.sh.in for tmpfs(5), could you look at
> http://www.freebsd.org/cgi/query-pr.cgi?pr=168836 for details.

Yes, doing this in the rc.d script is especially important for things in
/tmp since it's pretty common for it to start clean at boot time.

hth,

Doug

-- 

    This .signature sanitized for your protection