From owner-cvs-src@FreeBSD.ORG  Fri Aug 19 11:51:06 2005
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5612F16A448
	for <cvs-src@FreeBSD.org>; Fri, 19 Aug 2005 11:51:06 +0000 (GMT)
	(envelope-from lehmann@ans-netz.de)
Received: from avocado.salatschuessel.net (avocado.salatschuessel.net
	[83.136.81.184])
	by mx1.FreeBSD.org (Postfix) with ESMTP id EA7B143D49
	for <cvs-src@FreeBSD.org>; Fri, 19 Aug 2005 11:51:04 +0000 (GMT)
	(envelope-from lehmann@ans-netz.de)
Received: (qmail 79113 invoked by uid 89); 19 Aug 2005 11:50:21 -0000
Message-ID: <20050819115021.79112.qmail@avocado.salatschuessel.net>
References: <200508190356.j7J3uj5D095435@repoman.freebsd.org>
	<43059925.3090701@FreeBSD.org> <867jeiguft.fsf@xps.des.no>
In-Reply-To: <867jeiguft.fsf@xps.des.no>
From: "Oliver Lehmann" <lehmann@ans-netz.de>
To: des@des.no (Dag-Erling =?utf-8?B?U23DuHJncmF2?=)
Date: Fri, 19 Aug 2005 13:50:21 +0200
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: quoted-printable
Cc: cvs-src@FreeBSD.org, Doug Barton <dougb@FreeBSD.org>,
	Colin Percival <cperciva@FreeBSD.org>, cvs-all@FreeBSD.org,
	src-committers@FreeBSD.org
Subject: Re: cvs commit: src/sys/conf newvers.sh
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 19 Aug 2005 11:51:06 -0000

Dag-Erling Sm=C3=B8rgrav writes: 

> Doug Barton <dougb@FreeBSD.org> writes:
>> 1. A "better" way (IMO) to write: 
>>
>> if [ "X${BRANCH_OVERRIDE}" !=3D "X" ]; then 
>>
>> is 
>>
>> case "${BRANCH_OVERRIDE}" in
>> '')=09;;
>> *)=09BRANCH=3D${BRANCH_OVERRIDE} ;;
>> esac
> 
> ITYM  [ -z "${BRANCH_OVERRIDE}" ]

The "original" reason why the "X-comparing" was used is that there are so=
me 
ancient test/shell implementations with problems in case the variable to 
test starts with a minus-sign (-) because this will be interpreted as an 
argument. But since newvers.sh is only expected to run on FreeBSD it is n=
ot 
really needed but doesn't hurt too. 

  Greetings, Oliver