From nobody Mon Dec 25 13:59:09 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SzKJh1hlrz54kPF for ; Mon, 25 Dec 2023 13:59:16 +0000 (UTC) (envelope-from mike@karels.net) Received: from mail2.karels.net (mail2.karels.net [3.19.118.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "freebsd", Issuer "freebsd" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SzKJg52Gtz3HlN; Mon, 25 Dec 2023 13:59:15 +0000 (UTC) (envelope-from mike@karels.net) Authentication-Results: mx1.freebsd.org; none Received: from mail2.karels.net (localhost [IPv6:0:0:0:0:0:0:0:1]) by mail2.karels.net (8.17.1/8.17.1) with ESMTP id 3BPDx9iJ090421; Mon, 25 Dec 2023 07:59:09 -0600 (CST) (envelope-from mike@karels.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=karels.net; s=mail2; t=1703512750; bh=P4Jyqp/jSOExXC3WS6mkmr3SBTIIMSizeB7U4uFSbRA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Eyn/bYJKF+cV1VKHkD07EpVU88I+mh2l07ont3gjSrcUi/G9/Jrl1Z4I7VVx55iBl DRWFces0Y2hpPmDegzZaHYdt6436RKOhJChvD6jR7Zx+6D6HxL/u7XclzkHwqG/SPs f0pOP5AWb3remqCxOsr7oUYn0np+KxbjRgRJ7d6KYHCdZZ/p/SQv/DZfLttcicUhKy 7IH0IQbHSuHLV03ZRXgF08LhXOq1q+Pq0xANX6acjRmlQAlzJaP6GF/cquZ8pr+pYs VdOfeQsHnKzCf69oI44F5QKkaQN1j80FK0lsQ5jOnoPwBIiohHyNCJDr2/gr9bIWfi aGQNzuD5hyPHw== Received: from [10.0.2.130] ([73.62.165.147]) by mail2.karels.net with ESMTPSA id 4tqQNK2KiWUzYQEAs/W3XQ (envelope-from ); Mon, 25 Dec 2023 07:59:09 -0600 From: Mike Karels To: d@delphij.net Cc: Craig Leres , Konstantin Belousov , freebsd-current@freebsd.org Subject: Re: Proposal: Disable compression of newsyslog by default Date: Mon, 25 Dec 2023 07:59:09 -0600 X-Mailer: MailMate (1.14r6015) Message-ID: In-Reply-To: References: <71C3C779-ACD1-4FF4-A213-5DBCD7707ED7@karels.net> List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16509, ipnet:3.16.0.0/14, country:US] X-Spamd-Bar: ---- X-Rspamd-Queue-Id: 4SzKJg52Gtz3HlN On 25 Dec 2023, at 2:12, Xin Li wrote: > On 2023-12-23 14:17, Mike Karels wrote: >> On 23 Dec 2023, at 15:23, Craig Leres wrote: >> >>> On 12/23/23 06:52, Konstantin Belousov wrote: >>>> This is strange change at best. I have no opinion about the disabli= ng >>>> of compression of the rotated logs by default, but we already have k= nobs >>>> to do that. Adding a knob that disables (or enables) other knobs to= work >>>> is weird. >>> >>> I totally agree. This moves the compression knob from the config file= to the command line. And what if the user wants some but not all files t= o be compressed? Or wants to use different compression with different log= files? >> >> Another possibility would be to introduce some simple form of variable= s in >> newsyslog.conf, replacing J by a variable reference, with the variable= >> being set near the beginning. E.g. >> >> V=3Dzstd (or just V=3D for none?) >> ... $V >> ... $V >> >> Then there would be one global change, and much easier changing of the= >> default. >> >> It would also be possible to add /etc/newsyslog.local.conf a= t the >> beginning, and set variables there, making changes to the default file= less >> painful in the future. > > I've implemented support of in https://reviews.freebsd.org/D= 43174 . Let's don't add macro or variables to newsyslog.conf as it would= be a nightmare for compatibility with other newsyslog variants of other = BSDs. Looks like there is a fair amount of divergence from NetBSD, at least; I don't think compatibility with other BSDs is a significant factor. Compatibility with older FreeBSD is a bigger consideration. An intermediate possibility would be to add an option letter for the default compression to be used in each entry, and use to set that default. It seems wrong to attempt to use zstd with opti= on letters like J; it's contradictory, if not confusing. It's still a knob to disable other knobs, although it is in the right file. Mike