From owner-svn-src-head@FreeBSD.ORG  Fri Feb 24 20:31:13 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0D3F3106564A;
	Fri, 24 Feb 2012 20:31:13 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id D34638FC13;
	Fri, 24 Feb 2012 20:31:12 +0000 (UTC)
Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [96.47.65.170])
	by cyrus.watson.org (Postfix) with ESMTPSA id 6D6E346B0A;
	Fri, 24 Feb 2012 15:31:12 -0500 (EST)
Received: from jhbbsd.localnet (unknown [209.249.190.124])
	by bigwig.baldwin.cx (Postfix) with ESMTPSA id EDD0DB940;
	Fri, 24 Feb 2012 15:31:11 -0500 (EST)
From: John Baldwin <jhb@freebsd.org>
To: Bruce Evans <brde@optusnet.com.au>
Date: Fri, 24 Feb 2012 15:12:23 -0500
User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p10; KDE/4.5.5; amd64; ; )
References: <201202232108.q1NL8LeB023212@svn.freebsd.org>
	<20120225044912.Y2319@besplex.bde.org>
In-Reply-To: <20120225044912.Y2319@besplex.bde.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201202241512.23271.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
	(bigwig.baldwin.cx); Fri, 24 Feb 2012 15:31:12 -0500 (EST)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r232072 - head/usr.bin/kdump
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 24 Feb 2012 20:31:13 -0000

On Friday, February 24, 2012 12:57:23 pm Bruce Evans wrote:
> On Thu, 23 Feb 2012, John Baldwin wrote:
> 
> > Log:
> >  Pretty-print the advice constants passed to posix_fadvise(2).
> 
> > Modified: head/usr.bin/kdump/kdump.c
> > 
==============================================================================
> > --- head/usr.bin/kdump/kdump.c	Thu Feb 23 21:07:16 2012	(r232071)
> > +++ head/usr.bin/kdump/kdump.c	Thu Feb 23 21:08:21 2012	(r232072)
> > @@ -1014,6 +1014,15 @@ ktrsyscall(struct ktr_syscall *ktr, u_in
> > 				}
> > 				capname(arg);
> > 				break;
> > +			case SYS_posix_fadvise:
> > +				print_number(ip,narg,c);
> > +				print_number(ip,narg,c);
> > +				print_number(ip,narg,c);
> > ...
> 
> Any chance of prettyprinting the sources too?  The (macro) definition
> was already uglyprinted, but kdump is fairly KNF-conformant (unlike
> truss), and doesn't use uglyprinting when invoking print_number()
> except for here.

Oops, I originally did this on 8 where it still has the wrong style.
I'll fix.

-- 
John Baldwin