From owner-cvs-src@FreeBSD.ORG  Sat Aug 13 12:01:55 2005
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.ORG
Delivered-To: cvs-src@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 4C80216A41F;
	Sat, 13 Aug 2005 12:01:55 +0000 (GMT)
	(envelope-from ache@nagual.pp.ru)
Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 9C5BF43D46;
	Sat, 13 Aug 2005 12:01:54 +0000 (GMT)
	(envelope-from ache@nagual.pp.ru)
Received: from nagual.pp.ru (ache@localhost [127.0.0.1])
	by nagual.pp.ru (8.13.4/8.13.4) with ESMTP id j7DC1oSs033303;
	Sat, 13 Aug 2005 16:01:50 +0400 (MSD)
	(envelope-from ache@nagual.pp.ru)
Received: (from ache@localhost)
	by nagual.pp.ru (8.13.4/8.13.4/Submit) id j7DC1oWA033302;
	Sat, 13 Aug 2005 16:01:50 +0400 (MSD) (envelope-from ache)
Date: Sat, 13 Aug 2005 16:01:50 +0400
From: Andrey Chernov <ache@FreeBSD.ORG>
To: "Tim J. Robbins" <tjr@FreeBSD.ORG>
Message-ID: <20050813120150.GA33192@nagual.pp.ru>
Mail-Followup-To: Andrey Chernov <ache@freebsd.org>,
	"Tim J. Robbins" <tjr@FreeBSD.ORG>, src-committers@FreeBSD.ORG,
	cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG
References: <200508130230.j7D2UGSp002570@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200508130230.j7D2UGSp002570@repoman.freebsd.org>
User-Agent: Mutt/1.5.9i
Cc: cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG
Subject: Re: cvs commit: src/lib/libc/regex regex2.h
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 13 Aug 2005 12:01:55 -0000

On Sat, Aug 13, 2005 at 02:30:16AM +0000, Tim J. Robbins wrote:
> tjr         2005-08-13 02:30:16 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     lib/libc/regex       regex2.h 
>   Log:
>   Change OUT from -2 to CHAR_MIN-1, making it impossible for it to
>   inadvertently match a negative char in the RE being compiled.

It seems this commit may mask the bug where signed comparison used.
Better fix perhaps to make compared char unsigned in all places, i.e.
	if (-2 == (unsigned char)'\254')

-- 
http://ache.pp.ru/