From owner-freebsd-current@FreeBSD.ORG Tue Oct 17 02:41:10 2006 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A128A16A416; Tue, 17 Oct 2006 02:41:10 +0000 (UTC) (envelope-from bde@zeta.org.au) Received: from mailout1.pacific.net.au (mailout1-3.pacific.net.au [61.8.2.210]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5B95543D7E; Tue, 17 Oct 2006 02:41:07 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au [61.8.2.163]) by mailout1.pacific.net.au (Postfix) with ESMTP id 9597D24D390; Tue, 17 Oct 2006 12:41:06 +1000 (EST) Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246]) by mailproxy2.pacific.net.au (Postfix) with ESMTP id 60CF827403; Tue, 17 Oct 2006 12:41:05 +1000 (EST) Date: Tue, 17 Oct 2006 12:41:04 +1000 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: Cheng-Lung Sung In-Reply-To: <20061017021407.GA738@FreeBSD.csie.nctu.edu.tw> Message-ID: <20061017123629.X67815@delplex.bde.org> References: <20061015135710.A28897E98D@FreeBSD.csie.nctu.edu.tw> <20061016011559.W61639@delplex.bde.org> <200610161431.25228.jhb@freebsd.org> <20061017021407.GA738@FreeBSD.csie.nctu.edu.tw> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Mailman-Approved-At: Tue, 17 Oct 2006 02:58:28 +0000 Cc: freebsd-hackers@freebsd.org, freebsd-bugs@freebsd.org, freebsd-current@freebsd.org, FreeBSD-gnats-submit@freebsd.org Subject: Re: kern/104436: [PATCH] sys/sem.h should include sys/types.h X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Oct 2006 02:41:10 -0000 On Tue, 17 Oct 2006, Cheng-Lung Sung wrote: > On Mon, Oct 16, 2006 at 02:31:24PM -0400, John Baldwin wrote: >> Is this better? >> ... > Thanks, I didn't go through the whole sem.h. > Also, it seems we should put these parts before 'sturct semid_ds'. > or say, after we include sys/ipc.h (which include sys/_types.h) Yes, that is especially needed for time_t, since it is the only one of the typedef'ed types used early in sys/sem.h. The others might be needed later when the non-typedefed types are cleaned up. (sys/ipc.h needs cleaning up more. It still spells uid_t as "unsigned short", but uids aren't that short...) Bruce