From owner-svn-ports-all@FreeBSD.ORG Mon Oct 28 09:57:48 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 1033) id DA303FD6; Mon, 28 Oct 2013 09:57:48 +0000 (UTC) Date: Mon, 28 Oct 2013 09:57:48 +0000 From: Alexey Dokuchaev To: Sunpoet Po-Chuan Hsieh Subject: Re: svn commit: r331685 - head/textproc/asciidoc Message-ID: <20131028095748.GA55611@FreeBSD.org> References: <201310261327.r9QDR71V076039@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201310261327.r9QDR71V076039@svn.freebsd.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Oct 2013 09:57:48 -0000 On Sat, Oct 26, 2013 at 01:27:07PM +0000, Sunpoet Po-Chuan Hsieh wrote: > New Revision: 331685 > URL: http://svnweb.freebsd.org/changeset/ports/331685 > > post-patch: > .for conf_file in ${CONF_FILES} > - @cd ${WRKSRC} && ${MV} ${conf_file} ${conf_file}.sample > + @cd ${WRKSRC}/ && ${MV} ${conf_file} ${conf_file}.sample I could never understand why people add trailing slashes everywhere: it is useless [1], it looks ugly, it makes lines longer, it adds noise to the logs, etc., etc., Why, really, do you need a slash after directory you're cd'ing into? ./danfe [1] when people add slashes after destination paths for install(8), I also think it's silly, but at least there is a benefit of early warning (vs. silently installing as a regular file if directory is missins). Do I miss some magic about cd that warrants a trailing slash?