Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 6 Mar 2020 12:02:43 +0000 (UTC)
From:      Hans Petter Selasky <hselasky@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org
Subject:   svn commit: r358697 - stable/11/sys/dev/usb/input
Message-ID:  <202003061202.026C2hFJ025837@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: hselasky
Date: Fri Mar  6 12:02:42 2020
New Revision: 358697
URL: https://svnweb.freebsd.org/changeset/base/358697

Log:
  MFC r358609:
  Restart the USB keyboard repeat timer at every valid key-press.
  
  This fixes a regression issue after r357861.
  
  Reported by:	James Wright <james.wright@jigsawdezign.com>
  PR:	224592
  PR:	233884
  Sponsored by:	Mellanox Technologies

Modified:
  stable/11/sys/dev/usb/input/ukbd.c
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/sys/dev/usb/input/ukbd.c
==============================================================================
--- stable/11/sys/dev/usb/input/ukbd.c	Fri Mar  6 12:01:58 2020	(r358696)
+++ stable/11/sys/dev/usb/input/ukbd.c	Fri Mar  6 12:02:42 2020	(r358697)
@@ -543,15 +543,9 @@ ukbd_interrupt(struct ukbd_softc *sc)
 				if (ukbd_is_modifier_key(key))
 					continue;
 
-				/*
-				 * Check for first new key and set
-				 * initial delay and [re]start timer:
-				 */
-				if (sc->sc_repeat_key == 0) {
-					sc->sc_co_basetime = sbinuptime();
-					sc->sc_delay = sc->sc_kbd.kb_delay1;
-					ukbd_start_timer(sc);
-				}
+				sc->sc_co_basetime = sbinuptime();
+				sc->sc_delay = sc->sc_kbd.kb_delay1;
+				ukbd_start_timer(sc);
 
 				/* set repeat time for last key */
 				sc->sc_repeat_time = now + sc->sc_kbd.kb_delay1;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202003061202.026C2hFJ025837>