Date: Tue, 10 Sep 2013 10:11:04 -0600 From: John Hein <jhein@symmetricom.com> To: "O. Hartmann" <ohartman@zedat.fu-berlin.de> Cc: FreeBSD Ports <freebsd-ports@freebsd.org> Subject: Re: HELP! nvidia-driver patch: Weird REPLACE_CMD and command-line-sed behaviour. HELP! Message-ID: <21039.17560.260313.21258@gromit.timing.com> In-Reply-To: <21039.17348.897687.242628@gromit.timing.com> References: <20130910015144.41c88d52@thor.walstatt.dyndns.org> <21039.10674.968260.7845@gromit.timing.com> <20130910162616.6ce1d52f@thor.walstatt.dyndns.org> <21039.16301.572328.142329@gromit.timing.com> <20130910175544.3feb9029@thor.walstatt.dyndns.org> <21039.17348.897687.242628@gromit.timing.com>
next in thread | previous in thread | raw e-mail | index | archive | help
John Hein wrote at 10:07 -0600 on Sep 10, 2013:
> O. Hartmann wrote at 17:55 +0200 on Sep 10, 2013:
> > On Tue, 10 Sep 2013 09:50:05 -0600
> > John Hein <jhein@symmetricom.com> wrote:
> > > Actually I should have said you want:
> > >
> > > .if ${OSVERSION} > 1000055
> > >
> > > The API change to vm_map_find was made between shortly before 1000055.
> >
> >
> > I'm on FreeBSD 10.0-CURRENT #1 r255434: Tue Sep 10 02:01:02 CEST 2013
> > amd64 and when calling
> >
> > make -VOSVERSION in x11/nvidia-driver I receive
> >
> > 1000054
>
> You are in an unfortunate window between the moment the API change was
> committed (255426) and the OSVERSION was bumped (255449). That
> shouldn't happen ideally, but sometimes it does. The "backward" gap
> from 255426 to the last bump (255321) is larger than the "forward"
> gap, and in absence of better guidance, you should generally pick the
> OSVERSION larger than a particular API change to key off.
>
> Your false 1000054 is really 1000055 in spirit, but human committers
> just didn't catch on until a bit later. So you have to pick the
> lesser of two evils - which I am claiming is 1000055.
So if you buy that argument, I have a correction. What I meant was:
.if ${OSVERSION} > 1000054
(I had >= 1000055 in my head)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?21039.17560.260313.21258>